Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies in conda envs, both testing and deployment #152

Merged
merged 11 commits into from
Jun 30, 2023

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Jun 29, 2023

Trying out Python 3.10, also using latest releases of gufe (0.9.0) and openfe (0.10.1) for deployment envs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ef0040d) 82.20% compared to head (1fd3f35) 82.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files          21       21           
  Lines        2670     2670           
=======================================
  Hits         2195     2195           
  Misses        475      475           
Impacted Files Coverage Δ
alchemiscale/interface/client.py 90.84% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dotsdl
Copy link
Member Author

dotsdl commented Jun 29, 2023

@hmacdope can I get a review on these updates?

@dotsdl dotsdl requested a review from hmacdope June 29, 2023 07:41
Copy link
Collaborator

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one question about whether we should use a python build matrix if we are not actually dropping 3.9, but other than that 👍

.github/workflows/ci-integration.yml Show resolved Hide resolved
@dotsdl dotsdl merged commit d4d2675 into main Jun 30, 2023
@dotsdl dotsdl deleted the update-deps branch September 26, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants