MQTT Implementation and HiveMQ connection #40

Ti-ger · 2022-06-10T23:20:35Z

Closes #43

Pull Request Checklist

Author

Built code and tested locally
Removed any TODOs, etc.
Metioned the issue this PR closes
Good description of what the PR does written

Reviewer

Built and tested code locally
Fully understood the PR
All open conversations resolved

Ti-ger · 2022-06-10T23:26:48Z

Adds MQTT Support by using the ESP-IDF MQTT Client.
Also implements the CLI and some logic to delay commands when the Connection HiveMQ is disrupted.
TODOs:

Check if we really want to use this tcp client and this event-loop.
My guess is: this is exactly what Matter uses under the hood, but we should verify this.
Create a shared HiveMQ Account
Store credentials in a way not everybody can see them...

vringar · 2022-06-17T15:09:02Z

Just curious, why is this not implemented via another git submodule?
This seems to be a copy of a whole repository including Travis and Gitlab CI config?

Ti-ger · 2022-06-23T09:47:40Z

You are right, this is a leftover. I thought we may have to replace all the socket calls with "Matter Socket" calls and so on.
Luckily this was not necessary. I will remove all the files, thanks for the hint!

bowski23 · 2022-06-24T13:47:31Z

Don't worry about the force-pushed changes. This was done to get rid of the secrets stored in past commits.

…ed (yet)

* feat(subscribe): WIP for subscription Co-authored-by: TuCl <[email protected]> Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * feat(subscribing): WIP added callbacks Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: TuCl <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * feat(subscribe): WIP register own second level command Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: TuCl <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * feat(subscribe): WIP more stuff Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: TuCl <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * fixed Memory Error * fix(InteractionModelReports): remove non-existing method * feat(shell): implement subscribe commands * chore(chip): updated chip repo * everything we have done so far! * fix(BindingHandler): make matterHub compile again * first socket * feat(subscribe): WIP for subscription Co-authored-by: TuCl <[email protected]> Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * feat(subscribing): WIP added callbacks Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: TuCl <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * feat(subscribe): WIP register own second level command Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: TuCl <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * feat(subscribe): WIP more stuff Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: TuCl <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> * fixed Memory Error * fix(InteractionModelReports): remove non-existing method * feat(shell): implement subscribe commands * chore(chip): updated chip repo * everything we have done so far! * fix(BindingHandler): make matterHub compile again * first socket * Moved SubscribeCommands into its own file * Started with the implemententation of the subscription manager Signed-off-by: Maximilian Weisenseel <[email protected]> * Handover ;) * Compiles again * Starting subscription (hopefully) * Fixed initializers * WIP: Subscription refactoring * WIP subscription refactoring * remove build.log * remove MQTT stuff * Update src/main/BindingHandler.cpp Co-authored-by: Stefan Zabka <[email protected]> * Update src/main/BindingHandler.cpp Co-authored-by: Stefan Zabka <[email protected]> * Update src/main/SubscribeCommands.cpp Co-authored-by: Stefan Zabka <[email protected]> * Update SubscriptionManager.cpp Removed old comments * Update src/main/SubscriptionManager.cpp Co-authored-by: Stefan Zabka <[email protected]> * Update BindingHandler.h * Update SubscribeCommands.h * Update src/main/include/SubscriptionManager.h Co-authored-by: Stefan Zabka <[email protected]> Co-authored-by: TuCl <[email protected]> Co-authored-by: Emirhan Atabay <[email protected]> Co-authored-by: Jan Golebiowski <[email protected]> Co-authored-by: Maximilian Weisenseel <[email protected]> Co-authored-by: Maximilian Weisenseel <[email protected]>

vringar

This is mostly a first pass. I need to look through this more thoroughly.

src/main/CMakeLists.txt

src/main/Kconfig.projbuild

src/main/MQTTManager.cpp

src/main/include/MQTTManager.h

src/main/include/Subscription.h

…at/mqtt

Ti-ger changed the base branch from main to feat/subscribe June 10, 2022 23:21

Ti-ger self-assigned this Jun 10, 2022

Ti-ger linked an issue Jun 10, 2022 that may be closed by this pull request

MQTT Integration #41

Open

Ti-ger changed the base branch from feat/subscribe to main June 23, 2022 08:28

Ti-ger changed the base branch from main to feat/subscribe June 23, 2022 08:46

Ti-ger changed the base branch from feat/subscribe to main June 24, 2022 13:30

bowski23 force-pushed the feat/mqtt branch from f707577 to 3f18ee8 Compare June 24, 2022 13:45

vringar self-requested a review June 27, 2022 16:48

Ti-ger and others added 17 commits June 27, 2022 20:09

Added Commands for the MQTT Implementation

fb59193

Copied esp-mqtt, if this works out we whould probably fork it

b6d16d3

added skeleton of a MQTTManager

f8e7712

Well, even I didn't expect this would work 🙈

01b4425

actually used the commandline parameters and added the unsub command

6be5083

added some logic to delay commands if the connection is not establish…

ff6bfcf

…ed (yet)

renamed certificate

d57a2fd

Changed MQTT configuration from hardcoded to Kconfig

c62147c

simple mqtt example

44b62ed

Added Commands for the MQTT Implementation

04c75db

added skeleton of a MQTTManager

309c00f

Well, even I didn't expect this would work 🙈

e84e223

actually used the commandline parameters and added the unsub command

e4a1dd7

added some logic to delay commands if the connection is not establish…

8b66ee8

…ed (yet)

renamed certificate

c5c4f01

removed unnecessary files

80e1692

vringar force-pushed the feat/mqtt branch from 3f18ee8 to 992934b Compare June 27, 2022 18:40

Fixed leftover merge markers

32d818c

vringar suggested changes Jun 27, 2022

View reviewed changes

Ti-ger and others added 9 commits June 30, 2022 10:26

removed unused header

820881b

Update MQTTManager.h

fb72053

Update Subscription.h

c388c89

Update MQTTManager.cpp

ea5790c

Merge branch 'feat/mqtt' of github.com:OpenFogStack/matterHub into fe…

661f470

…at/mqtt

changed the DDATA format to be conform with our sparkplug specification

00c47f0

fixed chip tool to support "\!" in the ssid name (thanks AVM)

d34b3f7

noted the MQTT configuration in the README

0feb735

Changed subscribe to support callbacks, created first prototype for DCMD

76fd2af

vringar self-requested a review July 1, 2022 09:26

Ti-ger and others added 2 commits July 2, 2022 10:11

extended MQTT handling, added DCMD callback

7f72b5e

Merge branch 'main' into feat/mqtt

81e76e6

vringar closed this Jul 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MQTT Implementation and HiveMQ connection #40

MQTT Implementation and HiveMQ connection #40

Ti-ger commented Jun 10, 2022 •

edited by vringar

Loading

Ti-ger commented Jun 10, 2022 •

edited by bowski23

Loading

vringar commented Jun 17, 2022

Ti-ger commented Jun 23, 2022

bowski23 commented Jun 24, 2022

vringar left a comment

MQTT Implementation and HiveMQ connection #40

MQTT Implementation and HiveMQ connection #40

Conversation

Ti-ger commented Jun 10, 2022 • edited by vringar Loading

Pull Request Checklist

Author

Reviewer

Ti-ger commented Jun 10, 2022 • edited by bowski23 Loading

vringar commented Jun 17, 2022

Ti-ger commented Jun 23, 2022

bowski23 commented Jun 24, 2022

vringar left a comment

Choose a reason for hiding this comment

Ti-ger commented Jun 10, 2022 •

edited by vringar

Loading

Ti-ger commented Jun 10, 2022 •

edited by bowski23

Loading