Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

MQTT Implementation and HiveMQ connection #40

Closed
wants to merge 29 commits into from
Closed

MQTT Implementation and HiveMQ connection #40

wants to merge 29 commits into from

Conversation

Ti-ger
Copy link
Contributor

@Ti-ger Ti-ger commented Jun 10, 2022

Closes #43

Pull Request Checklist

Author

  • Built code and tested locally
  • Removed any TODOs, etc.
  • Metioned the issue this PR closes
  • Good description of what the PR does written

Reviewer

  • Built and tested code locally
  • Fully understood the PR
  • All open conversations resolved

@Ti-ger Ti-ger changed the base branch from main to feat/subscribe June 10, 2022 23:21
@Ti-ger
Copy link
Contributor Author

Ti-ger commented Jun 10, 2022

Adds MQTT Support by using the ESP-IDF MQTT Client.
Also implements the CLI and some logic to delay commands when the Connection HiveMQ is disrupted.
TODOs:

  • Check if we really want to use this tcp client and this event-loop.
    My guess is: this is exactly what Matter uses under the hood, but we should verify this.

  • Create a shared HiveMQ Account

  • Store credentials in a way not everybody can see them...

@Ti-ger Ti-ger self-assigned this Jun 10, 2022
@Ti-ger Ti-ger linked an issue Jun 10, 2022 that may be closed by this pull request
@vringar
Copy link
Contributor

vringar commented Jun 17, 2022

Just curious, why is this not implemented via another git submodule?
This seems to be a copy of a whole repository including Travis and Gitlab CI config?

@Ti-ger Ti-ger changed the base branch from feat/subscribe to main June 23, 2022 08:28
@Ti-ger Ti-ger changed the base branch from main to feat/subscribe June 23, 2022 08:46
@Ti-ger
Copy link
Contributor Author

Ti-ger commented Jun 23, 2022

You are right, this is a leftover. I thought we may have to replace all the socket calls with "Matter Socket" calls and so on.
Luckily this was not necessary. I will remove all the files, thanks for the hint!

@Ti-ger Ti-ger changed the base branch from feat/subscribe to main June 24, 2022 13:30
@bowski23
Copy link
Contributor

Don't worry about the force-pushed changes. This was done to get rid of the secrets stored in past commits.

@vringar vringar self-requested a review June 27, 2022 16:48
Ti-ger and others added 17 commits June 27, 2022 20:09
* feat(subscribe): WIP for subscription

Co-authored-by: TuCl <[email protected]>
Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* feat(subscribing): WIP added callbacks

Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: TuCl <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* feat(subscribe): WIP register own second level command

Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: TuCl <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* feat(subscribe): WIP more stuff

Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: TuCl <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* fixed Memory Error

* fix(InteractionModelReports): remove non-existing method

* feat(shell): implement subscribe commands

* chore(chip): updated chip repo

* everything we have done so far!

* fix(BindingHandler): make matterHub compile again

* first socket

* feat(subscribe): WIP for subscription

Co-authored-by: TuCl <[email protected]>
Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* feat(subscribing): WIP added callbacks

Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: TuCl <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* feat(subscribe): WIP register own second level command

Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: TuCl <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* feat(subscribe): WIP more stuff

Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: TuCl <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>

* fixed Memory Error

* fix(InteractionModelReports): remove non-existing method

* feat(shell): implement subscribe commands

* chore(chip): updated chip repo

* everything we have done so far!

* fix(BindingHandler): make matterHub compile again

* first socket

* Moved SubscribeCommands into its own file

* Started with the implemententation of the subscription manager

Signed-off-by: Maximilian Weisenseel <[email protected]>

* Handover ;)

* Compiles again

* Starting subscription (hopefully)

* Fixed initializers

* WIP: Subscription refactoring

* WIP subscription refactoring

* remove build.log

* remove MQTT stuff

* Update src/main/BindingHandler.cpp

Co-authored-by: Stefan Zabka <[email protected]>

* Update src/main/BindingHandler.cpp

Co-authored-by: Stefan Zabka <[email protected]>

* Update src/main/SubscribeCommands.cpp

Co-authored-by: Stefan Zabka <[email protected]>

* Update SubscriptionManager.cpp

Removed old comments

* Update src/main/SubscriptionManager.cpp

Co-authored-by: Stefan Zabka <[email protected]>

* Update BindingHandler.h

* Update SubscribeCommands.h

* Update src/main/include/SubscriptionManager.h

Co-authored-by: Stefan Zabka <[email protected]>

Co-authored-by: TuCl <[email protected]>
Co-authored-by: Emirhan Atabay <[email protected]>
Co-authored-by: Jan Golebiowski <[email protected]>
Co-authored-by: Maximilian Weisenseel <[email protected]>
Co-authored-by: Maximilian Weisenseel <[email protected]>
Copy link
Contributor

@vringar vringar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly a first pass. I need to look through this more thoroughly.

src/main/CMakeLists.txt Outdated Show resolved Hide resolved
src/main/Kconfig.projbuild Show resolved Hide resolved
src/main/MQTTManager.cpp Show resolved Hide resolved
src/main/MQTTManager.cpp Show resolved Hide resolved
src/main/include/MQTTManager.h Show resolved Hide resolved
src/main/include/Subscription.h Show resolved Hide resolved
src/main/include/Subscription.h Show resolved Hide resolved
@vringar vringar self-requested a review July 1, 2022 09:26
@vringar vringar closed this Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform subscription information into MQTT message MQTT Integration
3 participants