Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging downloads with link #1020

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix hanging downloads with link #1020

merged 2 commits into from
Aug 14, 2023

Conversation

zacck
Copy link
Contributor

@zacck zacck commented Aug 11, 2023

Notes for the reviewer

Bug fix for hanging downloads when exporting project yaml

Related issue

Fixes #921

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (036e5ca) 85.73% compared to head (1282c39) 85.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.01%     
==========================================
  Files         174      174              
  Lines        4964     4962       -2     
==========================================
- Hits         4256     4254       -2     
  Misses        708      708              
Files Changed Coverage Δ
lib/lightning_web/live/project_live/settings.ex 97.40% <ø> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stuartc stuartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @zacck, I did remove the event handler that CodeCov pointed out wasn't being tested (and wasn't being used anymore).

@stuartc stuartc merged commit 5bee89a into main Aug 14, 2023
@stuartc stuartc deleted the download-limbo-fix branch August 14, 2023 08:50
@zacck
Copy link
Contributor Author

zacck commented Aug 14, 2023

Thanks for the save @stuartc much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export button hanging in limbo after download?
2 participants