Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Build Scans on develocity.commonhaus.dev #2543

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

bdemers
Copy link
Contributor

@bdemers bdemers commented Sep 9, 2024

cc: @velo

Note

This repo (or org) will need a secret named DEVELOCITY_ACCESS_KEY
(This was recently done for Morphia, the process should be the same here.)

Copy link
Member

@kdavisk6 kdavisk6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting back up to speed here. I'm assuming this is part of the projects enrollment in the Commonhaus Foundation and this is one of the benefits, considering Develocity is a pay service?

@bdemers
Copy link
Contributor Author

bdemers commented Sep 11, 2024

I'm still getting back up to speed here. I'm assuming this is part of the projects enrollment in the Commonhaus Foundation and this is one of the benefits, considering Develocity is a pay service?

@kdavisk6, correct. Its a way to get some observability/metrics into your build. What takes the longest, track flaky tests, compare builds to see what changed between them (dependencies, java version, etc).
There is also other functionality like build caching, and ways to speed up your tests, but... collecting metrics is always the first steps (measure before optimization).

@kdavisk6
Copy link
Member

Great. I'll approve the PR, but wait to test the workflows until we get the Secret configured.

@kdavisk6 kdavisk6 added the ready to merge Will be merged if no other member ask for changes label Sep 14, 2024
Previous commit added a secret using an incorrectly formatted YAML file
@bdemers
Copy link
Contributor Author

bdemers commented Sep 16, 2024

Looks like there was a YAML formatting error:
https://github.com/OpenFeign/feign/actions/runs/10776636436

Fixed in: 41f3cc9

@velo velo merged commit 8cede12 into OpenFeign:master Sep 16, 2024
5 checks passed
@bdemers bdemers deleted the build-scans branch September 16, 2024 15:49
velo pushed a commit that referenced this pull request Oct 7, 2024
* Enable Build Scans on develocity.commonhaus.dev

* Correcting error in codeql-analysis workflow

Previous commit added a secret using an incorrectly formatted YAML file
velo pushed a commit that referenced this pull request Oct 8, 2024
* Enable Build Scans on develocity.commonhaus.dev

* Correcting error in codeql-analysis workflow

Previous commit added a secret using an incorrectly formatted YAML file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants