Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression pattern compilation on android #2136

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

iProdigy
Copy link
Contributor

The ICU regex engine used by Android requires } in EXPRESSION_PATTERN to be escaped.

Fixes java.lang.NoClassDefFoundError: feign.template.Expressions on Android (reported by @Awakened-Redstone)

Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a unit test around this? Just to prevent breaking again in the future

@iProdigy iProdigy requested a review from velo July 26, 2023 16:09
@velo velo merged commit 59a568e into OpenFeign:master Jul 28, 2023
1 check passed
@iProdigy iProdigy deleted the patch-1 branch August 3, 2023 15:56
velo pushed a commit that referenced this pull request Oct 7, 2024
* Fix expression pattern compilation on android

* Add test cases

* Add license header

* Reformat
velo pushed a commit that referenced this pull request Oct 8, 2024
* Fix expression pattern compilation on android

* Add test cases

* Add license header

* Reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants