Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http_method tag to micrometer metrics #1968

Merged
merged 7 commits into from
Mar 17, 2023
Merged

Add http_method tag to micrometer metrics #1968

merged 7 commits into from
Mar 17, 2023

Conversation

rnavarropiris
Copy link
Contributor

Add HTTP method information as tag for micrometer HTTP requests.

@rnavarropiris
Copy link
Contributor Author

Addresses: #1631

Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the change, we just need to have CI happy too

@rnavarropiris
Copy link
Contributor Author

Thanks @velo!
I did see some syntax related error reported. I imported the eclipse settings into IntelliJ and reformatted the reported file, but the error persist.

Since I'm not sure what else could be wrong and I didn't see any troubleshooting notes ( I checked README, CONTRIBUTING & HACKING), could you lend me a hand/give me a hint? :)

@velo
Copy link
Member

velo commented Mar 9, 2023

Did you build the project locally?

@rnavarropiris
Copy link
Contributor Author

@velo
I tried (mvn package), but stumble against this error:

[ERROR] No plugin found for prefix 'feign-example-github' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/.../.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]
org.apache.maven.plugin.prefix.NoPluginFoundForPrefixException: No plugin found for prefix 'feign-example-github' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/.../.m2/repository), central (https://repo.maven.apache.org/maven2)]

Seems to happen when executing the task :feign-example-github :/

@velo velo merged commit bc0fcdb into OpenFeign:master Mar 17, 2023
velo pushed a commit that referenced this pull request Oct 7, 2024
* Add http_method tag to micrometer metrics

* Limit line length to 100 chars

* Applies eclipse-java-style to AbstractMetricsTestBase

* Fix AbstractMetricsTestBase format
velo pushed a commit that referenced this pull request Oct 8, 2024
* Add http_method tag to micrometer metrics

* Limit line length to 100 chars

* Applies eclipse-java-style to AbstractMetricsTestBase

* Fix AbstractMetricsTestBase format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants