-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http_method tag to micrometer metrics #1968
Add http_method tag to micrometer metrics #1968
Conversation
Addresses: #1631 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the change, we just need to have CI happy too
Thanks @velo! Since I'm not sure what else could be wrong and I didn't see any troubleshooting notes ( I checked README, CONTRIBUTING & HACKING), could you lend me a hand/give me a hint? :) |
Did you build the project locally? |
@velo
Seems to happen when executing the task |
* Add http_method tag to micrometer metrics * Limit line length to 100 chars * Applies eclipse-java-style to AbstractMetricsTestBase * Fix AbstractMetricsTestBase format
* Add http_method tag to micrometer metrics * Limit line length to 100 chars * Applies eclipse-java-style to AbstractMetricsTestBase * Fix AbstractMetricsTestBase format
Add HTTP method information as tag for micrometer HTTP requests.