This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update comments based on the template available at https://openfast.readthedocs.io/en/main/_downloads/e864ec3914cc13b6e94c9a49323cf996/TurbSim.inp The file in the readthedocs linked above contains more parameters- these have not been added. I mainly fixed a very confusing comment about the `UserFile` usage.
Conflicts: pyFAST/input_output/fast_input_file.py Fix small conflict related to number of lines on output channel list.
Thanks for doing that, let me know when it's ready to review. The examples in the folder examples should be run by the unittests. If some of them require binaries, then we'll have to skip parts of the examples. |
@jjonkman, could you review? |
Note: backward compatible
@ebranlard This is ready to be merged, pending @jjonkman's review. |
Uses the underlying AMR-Wind simulation class with a dummy grid to get the values. Lots of information is printed on the screen to help the user make the appropriate choice.
I'll merge this now, some things to consider for a future pull request:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a class for complete case creation.
Includes the following:
Does not include:
Still a draft PR because I will include examples. Will make a regular PR when that is done.