Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSbuild: updates for 4.0.0 release #2589

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented Dec 24, 2024

Ready to merge

Feature or improvement description
There are inconsistencies with the executable destinations and usage of OMP. Also updating the PlatformToolSet and TargetPlatformVersion so that VS doesn't annoy me with these suggestions.

  • AeroDsk - remove OMP (not needed)
  • SED - remove OMP (not needed)
  • HydroDyn - correct binary output location
  • MoorDyn - correct binary output location
  • SeaState - correct binary output location and naming
  • update PlatformToolSetand TargetPlatformVersion in MAPlib and Registry projects

Related issue, if one exists
None

Impacted areas of the software
VS builds only

Additional supporting information

Test results, if applicable
No test result changes

- ADsk     -- remove OMP (not needed)
- SED      -- remove OMP (not needed)
- HD       -- correct binary output location
- SeaState -- correct binary output location and naming
- update PlatformToolSet and TargetPlatformVersion in MAPlib and Registry projects
@andrew-platt andrew-platt added this to the v4.0.0 milestone Dec 24, 2024
@andrew-platt andrew-platt self-assigned this Dec 24, 2024
Copy link
Contributor

@bjonkman bjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrew-platt andrew-platt merged commit bf23b75 into OpenFAST:dev Dec 24, 2024
54 of 66 checks passed
@andrew-platt andrew-platt deleted the b/vsbuild_4.0.0 branch December 24, 2024 19:32
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants