Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LiDAR in IfW at FAST.Farm level #2569

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

andrew-platt
Copy link
Collaborator

Ready to merge

Feature or improvement description
The LiDAR sub-module inside InflowWind requires turbine specific information such as hub location. However, this information is not available at the FAST.Farm level instance of InflowWind. This was resulting in segmentation faults when someone attempted to use it at this level.

This PR disables the LiDAR submodule from use with the InflowWind module used at the FAST.Farm level.

Related issue, if one exists
#2316
#2324

Impacted areas of the software
InflowWind module at the FAST.Farm level only.

Additional supporting information
A few users have attempted to use the LiDAR sub-module at the FAST.Farm level and received segmentation faults. Since this is not something the code can really do, we are simply disabling it for now.

Test results, if applicable
No results change.

Copy link
Collaborator

@deslaughter deslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably would have reversed the logic and done LidarEnable = .true. in the registry file and set it to .false. where it's initialized in FAST.Farm. Otherwise, the flag will have to be set to false to achieve normal operation. For example, does this flag need to be set false in the ADI library or the InflowWind C Bindings?

@andrew-platt
Copy link
Collaborator Author

At present the Lidar doesn't output anything to file, but simply populates data to pass to the controller. In the ADI library and InflowWind c-bindings library, there are no provisions for a controller so Lidar shouldn't be used there.

I can change the logic on that, but I do thing we should default it to disabled.

@andrew-platt andrew-platt merged commit ee85fef into OpenFAST:rc-3.5.5 Dec 19, 2024
19 checks passed
@andrew-platt andrew-platt deleted the b/Lidar_SegFault branch December 19, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants