Allow ParseVar to parse file paths containing spaces. #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deslaughter
added
Module: NWTC Lib
Feature: Usage Support
Type: IO Readers/Writers
andrew-platt
approved these changes
Dec 12, 2024
bjonkman
reviewed
Dec 16, 2024
| @@ -2070,68 +2070,95 @@ SUBROUTINE GetWords ( Line, Words, NumWords, NumFound ) | |||
| CHARACTER(*), INTENT(IN) :: Line !< The string to search. | |||
| CHARACTER(*), INTENT(OUT) :: Words(NumWords) !< The array of found words. | |||
| INTEGER, OPTIONAL, INTENT(OUT) :: NumFound !< The number of words found | |||
| LOGICAL, OPTIONAL, INTENT(OUT) :: IgnoreQuotes !< Flag to ignore quotes (process as whitespace) | |||
There was a problem hiding this comment.
shouldn't this be INTENT(IN)?
There was a problem hiding this comment.
that should! Good catch.
There was a problem hiding this comment.
Fixed directly on rc-3.5.5 with a62d877
This was referenced Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR attempts to add support for file paths containing spaces when the paths are parsed with
ParseVar. TheIsPathoptional argument was added toParseChVarso this flag can be added instances whereParseVaris use to parse a path. This required modifications toGetWordsto respect or ignore single or double quotes.Related issue, if one exists
#2552
Impacted areas of the software
NWTC_IO.f90and AeroDyn, HydroDyn, InflowWind input reading functions.