Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: typo was preventing docker build upload to GH #2498

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

andrew-platt
Copy link
Collaborator

Ready to merge, pending review by @mayankchetan

Feature or improvement description
A typo in the github action for deploying docker containers was preventing the upload of a finalized docker container.

Related issue, if one exists
https://github.com/OpenFAST/openfast/actions/runs/11583019546/job/32247290012

Impacted areas of the software
Automated Docker container deployment on GitHub only.

Additional supporting information
N/A

Test results, if applicable
N/A

@andrew-platt andrew-platt added the System: Docker Dockerfiles and recipes label Nov 4, 2024
@andrew-platt andrew-platt self-assigned this Nov 4, 2024
@andrew-platt andrew-platt added this to the v3.5.5 milestone Nov 4, 2024
Copy link
Contributor

@mayankchetan mayankchetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We might want to manually trigger 3.5.4 image generation soon just for completeness.

@mayankchetan
Copy link
Contributor

@andrew-platt, have a PR to your branch here: andrew-platt#26

Addressing the capitalization issue for GHCR

repository name must be lowercase
@andrew-platt andrew-platt merged commit e7d378b into OpenFAST:rc-3.5.5 Nov 8, 2024
19 checks passed
@andrew-platt andrew-platt deleted the b/docker_build branch November 10, 2024 00:40
@andrew-platt andrew-platt mentioned this pull request Dec 19, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
System: Docker Dockerfiles and recipes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants