MD: Automatically detect the number of header lines in the WaveKin (wave elevation) file #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave elevation) file
…at t = 0. Also updated error messages.
RyanDavies19
approved these changes
Sep 26, 2024
andrew-platt
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
Previously, MoorDyn always assumes the wave-elevation input file to contain 2 lines of header. It can result in a segmentation fault if the file contains an incorrect number of header lines. This also prevents MoorDyn from directly using the SeaState wave-elevation output file as input, a common use case. This PR allows MoorDyn to automatically detect and skip header lines in the wave-elevation input file for added flexibility.
Impacted areas of the software
MoorDyn
Test results, if applicable
No change to test results. All tests passed.