ExtLd: require use of InflowWind #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove wind calculations inside ExtLd. These variables removed: - vel_mean - wind_dir - z_ref - shear_exp - Require use of InflowWind - remove following from OF library interface: - vel_mean_c - wind_dir_c - z_ref_c - shear_exp_c
andrew-platt
added
Module: InflowWind
C++ API
Module: ExtLoads
andrew-platt
force-pushed
the
b/ExtLd_use_IfW
branch
from
0de1c54 to
fb4a656
Compare
andrew-platt
force-pushed
the
b/ExtLd_use_IfW
branch
from
fb4a656 to
2786175
Compare
gantech
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks for getting this done Andy. After going through the implementation, I checked the 5MW_Restart regression test against the output of the fortran driver with CompAero set to 2. All channel diff norms are within 1e-12. This is good to go and a welcome reduction in complexity for blade-resolved FSI cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge. Requires testing with FSI CFD (after update to interface on that side).
Feature or improvement description
Originally the ExtLoad module was designed to provide a set of steady wind parameters to OpenFAST from FSI CFD (not sure if this is AMR-Wind or NALU-Wind). These parameters were used to calculate a steady wind profile for AeroDyn to use during the initial few rotations where AeroDyn and ExtLoad loads were blended (this was for initializing the CFD better).
However, after merging in the InflowWind pointers change, there was a bug with how this worked. After some discussion with @gantech and others, it was decided that the best approach would be to now require InflowWind with ExtLoad (previously this was not allowed) and have InflowWind handle all the wind for AeroDyn throughout the simulation. The following changes were made:
FAST_ExtLoads_Init):Related issue, if one exists
Issue brought up in discussions, not GH.
Impacted areas of the software
The C++ interface is affected.
Additional supporting information
Test results, if applicable
We still don't have a test case for this...