AeroDyn14 removal #2267
Merged
AeroDyn14 removal #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
1feed86 to
f261880
Compare
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
d0fc943 to
f445989
Compare
Logic error preventing this from getting written out
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
7260550 to
18128f8
Compare
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
13c6688 to
4cae989
Compare
- update docs to not mention AD14 - update error handling in parsing .fst files
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
4cae989 to
1da2488
Compare
Cases affected: - 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth - SD bugfixes changed loads slightly - hd_5MW_ITIBarge_DLL_WTurb_WavesIrr (Failed) - Time series were shortened, so wave time series are different - hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth - Different grid than in prior runs.
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
fb33bdd to
605bd42
Compare
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
ff6a1fa to
605bd42
Compare
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
58ef339 to
a12d9d3
Compare
NOTE: the FileInfo parsing compares names. This presents issues if the name is set to `BldFlDmp1` instead of `BldFlDmp(1)` -- this is the behaviour of RotorSE from WEIS. To get around this, we are not checking the names for some of the inputs.
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
f874d45 to
a207106
Compare
|
This PR also removes |
Remove bad driver cases (non-physical), and shorten a test
andrew-platt
force-pushed
the
f/AD14remove_attempt2
branch
from
aebac8e to
e8c7987
Compare
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Jul 16, 2024
andrew-platt
added a commit
that referenced
this pull request
Jul 16, 2024
bjonkman
added a commit
to bjonkman/openfast
that referenced
this pull request
Aug 16, 2024
Compare with OpenFAST#2267 The summary file stated AeroDyn had unknown version and date instead of leaving that blank. I think the issue was that the original code on the AD14 removal had the `ELSEIF` indented improperly so the ELSE section was removed with the AD14 section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for merging (regression tests must be dealt with first). This PR supercedes #1429 (that PR sat for too long).
Feature or improvement description
The AeroDyn14 module was a carry-over from FAST v7 to FAST v8 as a stop-gap while AeroDyn15 was under development. As such AeroDyn14 was never converted to the FAST Modular Framework; this created many code workarounds in ElastoDyn and in the openfast-library to get it to work. At this point AeroDyn15 is far more comprehensive than AeroDyn14 so very few users ever use it. Therefore the plan for many years has been to remove it entirely, and now we finally got around to it.
Also includes minor fixes for AD15 input files:
UA_Modcomments instead of the deprecatedAFAeroModcommentsRelated issue, if one exists
#527 -- bug with AD14 tower
#93 -- deprecating AD14
OpenFAST/r-test#43
Impacted areas of the software
There are some significant improvements to the glue code and ElastoDyn with the removal of AD14.
Additional supporting information
The regression tests that previously used AeroDyn14 have been updated to AeroDyn15, but have not been tuned correctly for the DBEMT parameters (in particular the
Tautime constants). Some of these cases also show instabilities and had been turned off as a result. We need to decide which cases we will simply remove, and which we will keep.Test results, if applicable
Regression tests with AD14 converted to AD15.