Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED: Add inputs for the off-diagonal terms of the platform moment of inertia matrix #2247

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

luwang00
Copy link
Contributor

@luwang00 luwang00 commented May 31, 2024

Feature or improvement description
This PR adds three new inputs in ElastoDyn for the off-diagonal terms of the platform moment of inertia matrix, Ixy, Iyz, and Izx. The ElastoDyn platform equations of motion are also updated to include these terms. The ElastoDyn input documentation is updated as well.

Impacted areas of the software
ElastoDyn

Test results, if applicable
r-test ElastoDyn input files have been updated with the three new inputs. The off-diagonal moment of inertia terms are set to zero in all existing r-tests, so no change to the results.

@andrew-platt andrew-platt requested a review from jjonkman June 20, 2024 15:50
Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luwang00. I agree with these equations, including the signs in the inertia dyadic (given that you've defined the cross-inertias with the negative sign). Just a few minor comments on registry descriptions...

modules/elastodyn/src/ElastoDyn_Registry.txt Outdated Show resolved Hide resolved
modules/elastodyn/src/ElastoDyn_Registry.txt Outdated Show resolved Hide resolved
modules/elastodyn/src/ElastoDyn_Registry.txt Outdated Show resolved Hide resolved
@luwang00
Copy link
Contributor Author

luwang00 commented Jun 21, 2024

Hi @andrew-platt, I think this PR is ready to merge. Thanks!

@andrew-platt andrew-platt self-assigned this Jun 24, 2024
@andrew-platt andrew-platt added this to the v4.0.0 milestone Jun 24, 2024
@andrew-platt andrew-platt merged commit 3d476c5 into OpenFAST:dev Jun 24, 2024
21 checks passed
@luwang00 luwang00 deleted the f/ED_FullMoI branch August 30, 2024 15:16
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants