ADI: disable OMP in AeroDyn_Inflow.f90 #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a compiler fault with OneAPI 2023.2 with LLVM (see issue OpenFAST#2135)
deslaughter
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
The use of OpenMP directives in AeroDyn_Inflow.f90 was causing a compiler fault with Intel OneAPI 2023.2 with LLVM
Related issue, if one exists
#2135
Impacted areas of the software
AeroDyn driver, only when steady winds generated by the driver are used.
Other Info
With the introduction of the FlowField data structure, we will be modifying how wind is handled in this module. This may result in removal of this section of code at that point (I don't remember for certain).