-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dockerfile and facilitate nrel/openfast
Docker Hub registry
#2124
Conversation
@deslaughter we can do either or both We'll know if the build fails because the workflow will show as a failure. We can even add a badge to the readme (or anywhere else on the internet) that shows if the latest build was successful. If you wanted to, we could automate GitHub releases of this repository and only release if the docker image builds on merge into |
It sounds like this might be the set of workflows we want then:
For context, building from scratch for |
that's a really long build time for |
I've just added the new workflows - let me know what you think |
I'm fixing a small issue with the test and automatic docker workflows; I'll confirm when it's done |
This is fixed now so I think that's everything ready apart from the pre-release to-dos in the PR description |
Whoops! I didn't mean to merge this just yet (and didn't intend to do it as a rebase merge). We can make some PR's to resolve the last questions:
|
@andrew-platt are you able to re-open this pull request so the new commits show up? |
@cortadocodes, unfortunately there isn't a good way to re-open the PR. We'll need to do a second PR with the updates (thanks for figuring those out!). Again, my apologies for accidentally merging this too early. |
No problem! |
@andrew-platt here's the new PR: #2139 |
Summary
This pull request updates the existing
Dockerfile
to facilitate the building of production-ready docker images of OpenFAST which can be pushed to a Docker Hub image repository and used by the community.Changes
linux/amd64
andlinux/aarch64
architectures and push them to a Docker Hub repositoryDockerfile
can be usedRelated issue
#1851
Impacted areas of the software
Only the
Dockerfile
inshare/docker/openfast_ubuntu/Dockerfile
and the GitHub Actions workflowsTest results
3.1.0
- I then ran it as a container, successfully ran theopenfast
CLI command with no parameters, and ran a successful analysis with some test input files3.5.2
- I then ran it as a container and successfully ran theopenfast
CLI command with no parameters3.1.0
and3.5.2
images to theoctue/openfast
Docker Hub repositoryPre-release to-dos
If the maintainers are happy with this pull request, we need to do the following things before merging:
NREL team:
nrel/openfast
docker reponrel/openfast
access to this repository's GitHub actions secretsDockerfile
is correct@cortadocodes
octue
tonrel
in docker workflow (docker repo and location of dockerfile)Dockerfile
up one level (this will remove the diff that's currently visible for the file, which is why I haven't moved it yet)