Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from PR #1932 #1946

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Conversation

andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented Dec 18, 2023

This is not ready for merging yet.

Feature or improvement description
A few minor bugs and inconsistencies were discovered after merging #1932.

  • Wrong name for the ExtLoads module in comment
  • replace m_FAST%t_global with t_now calculated from t_global in FAST_Subs::WriteOutputToFile call

Also added a check on the number of tower nodes when ExtInflow is used with CFD.

Related issue, if one exists

Impacted areas of the software

  • glue code

Additional supporting information

Test results, if applicable
No test results change with this PR

@andrew-platt andrew-platt added this to the v4.0.0 milestone Dec 18, 2023
@andrew-platt andrew-platt self-assigned this Dec 18, 2023
@andrew-platt andrew-platt changed the base branch from main to dev December 18, 2023 20:30
@andrew-platt andrew-platt added Module: ExtLoads For blade resolved CFD coupling Module: ExtInflow for inflow from CFD labels Dec 18, 2023
Replace argument `m_FAST%t_global` with calculated `t_global` in `FAST_SUBS::FAST_WriteOutput`
@andrew-platt
Copy link
Collaborator Author

@andrew-platt andrew-platt merged commit 5d8cc6a into OpenFAST:dev Dec 29, 2023
63 checks passed
@andrew-platt andrew-platt deleted the b/ExtLoads_mergeFix branch January 8, 2024 21:35
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: ExtInflow for inflow from CFD Module: ExtLoads For blade resolved CFD coupling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant