Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD: Initial AeroMap changes for AeroDyn and misc UA/DBEMT changes #1715

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

ebranlard
Copy link
Contributor

@ebranlard ebranlard commented Aug 3, 2023

This pull request is ready to be merged

Feature or improvement description
This pull request introduces:

  • If statements in AeroDyn to perform the linearization differently when the AeroMap flag is set
  • Uses UA%lin_xIndx in UA and AeroDyn to store the indices of the states in the operating point vector x_op
  • Uses utimes in DBEMT in cases the inputs are at multiple times (and not just dt and t+dt).
  • Uses double precision variables for some of the critical variables of UA
  • Prepares the ground for a followup pull request that will affect the test results (introducing feature to avoid linearization of non active UA states, use of a stiff integrator, introducing u%AvgDiskVel)

Impacted areas of the software
AeroDyn, UA, DBEMT

Additional supporting information
Keeping track of state indices can be difficult, in particular if we desactivate some UA nodes.
The AeroMap feature is progressively being introduced in OpenFAST. See #1631

Test results, if applicable
Should be unaffected

@ebranlard ebranlard requested a review from andrew-platt August 3, 2023 18:16
@ebranlard ebranlard self-assigned this Aug 3, 2023
@ebranlard ebranlard changed the title AD: Anitial AeroMap changes for AeroDyn and misc UA/DBEMT changes AD: Initial AeroMap changes for AeroDyn and misc UA/DBEMT changes Aug 3, 2023
@ebranlard ebranlard added this to the v4.0.0 milestone Aug 3, 2023
@ebranlard ebranlard merged commit 2199ad3 into OpenFAST:dev Aug 3, 2023
@ebranlard ebranlard deleted the f/ad-ua-dbemt-lin-aeromap3 branch August 25, 2023 21:41
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants