Improvements to regression test python scripts #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy input files needed for HydroDyn test cases (some files are stored in the glue-codes directory, so it will error if module is tested before glue-code is) - Return the completion code if a simulation did not run to the end (as opposed to comparing old results with no clear indication that the results are old) - fix missing variable in `executePythonRegressionCase.py` - if test_data and baseline_data are not the same size, return NaNs. We don't currently have a way to test if any of the columns are the same. - summary HTML file now contains columns for `Completion Code` and a link to the `.log` file containing screen output when the case ran (helpful for debugging) - fixed the issue where a blank line was printed to the screen for every line read in a ascii output file - fixed issue where specifying `-p` wouldn't generate plots but `-p=true` would (at least on my system) - make source directory an absolute path to fix issue when scripts to run module drivers change the working directory - add a `-module` optional argument to `manualRegressionTest.py` to allow it to execute the driver regression tests
…t channels this still doesn't check that the outputs are in the same order, so we could be comparing different channels against each other....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
After using the manual regression test python scripts for debugging recent HydroDyn module changes, I made the following improvements to the scripts:
NaNinstead of causing a fatal error in the Python script.executePythonRegressionCase.pythat has now been fixed.manualRegressionTest.pyscript has been modified to allow it to also execute module driver regression tests (not just the openfast reg tests):-moduleflag to allow the user to specify a particular module to run (e.g.-module=hydrodynor-module=Inflowwind).-moduleflag, it will work as before with openfast regression tests.-pwouldn't generate plots but-p=truewould. I updated the arguments to allow the-poption to work, too.Impacted areas of the software
regression test scripts: mostly the manual tests
Additional supporting information
These changes have been incorporated into #1008, but I'm pulling them into a separate PR so they could theoretically get incorporated into the OpenFAST/dev branch sooner.
Test results, if applicable
This shouldn't change any regression test results, but the screen output may have fewer blank lines.