Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HydroDyn added mass at end of member may not computed properly #992

Closed
ebranlard opened this issue Feb 7, 2022 · 1 comment · Fixed by #1291
Closed

HydroDyn added mass at end of member may not computed properly #992

ebranlard opened this issue Feb 7, 2022 · 1 comment · Fixed by #1291
Assignees
@ebranlard
Labels
Module: HydroDyn Type: Bug

Comments

@ebranlard
Copy link
Contributor

Bug description
The variable v2D in the line below is (3x1):
https://github.com/OpenFAST/openfast/blob/dev/modules/hydrodyn/src/Morison.f90#L2125
Therefore, the expression matmul(transpose(v2D), v2D) returns a scalar.

I believe the equation should be replaced by matmul( (v2d, transpose(v2d) ) to return a 3x3 matrix.

In my windows gfortran value, the statement is interpreted in a weird way, and the scalar value is placed in the element (3,3) of AM_End, which is quite surprising.

I'll submit a pull request.

OpenFAST Version
Openfast dev as of 2/7/2022
ebranlard added a commit to ebranlard/openfast that referenced this issue Feb 7, 2022
@ebranlard
Fix HD added mass on member end (Close OpenFAST#992)
104f8fc
@ebranlard ebranlard self-assigned this Feb 11, 2022
@ebranlard ebranlard mentioned this issue Feb 11, 2022
Merged
1 task
ebranlard added a commit to ebranlard/openfast that referenced this issue Mar 11, 2022
@ebranlard
HD: Fix HD added mass on member end (scaling factor) (Close OpenFAST#992
81df672 
)
@ebranlard ebranlard mentioned this issue Mar 11, 2022
Merged
@andrew-platt andrew-platt mentioned this issue Mar 16, 2022
Open
andrew-platt added a commit that referenced this issue Sep 8, 2022
@andrew-platt
Merge pull request #999 from ebranlard/f/hd-am-end
0668079 
Fix HD added mass on member end (Close #992)
@ebranlard
Copy link
Contributor Author

Fixed with #999

@rafmudaf rafmudaf mentioned this issue Oct 27, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebranlard ebranlard

Labels
Module: HydroDyn Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OpenFAST v3.3.0 OpenFAST/openfast
1 participant
@ebranlard