-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monetary price and currency #640
Conversation
About the definition of monetary price: A monetary price is more concretely an economic value, quantity value is the superclass of economic value. |
Good catch. Now fixed in definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added a FIBO-reference for currency, but not for monetary price (https://spec.edmcouncil.org/fibo/ontology/FND/Accounting/CurrencyAmount/Price).
Also, could you update the changelog for this pr and the others as well?
Reference now added.
Changelog now updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now everything looks fine to me. Thanks for implementing!
Add 'monetary price' and 'currency' with the definitions 'A monetary price is a quantity value that describes the amount of money requested, expected, required or given in exchange for something else.' and 'A unit which is a measure of the medium of an exchange value, defined by reference to the geographical location of the monetary authorities responsible for it.' respectively as per the FIBO sheet.
Closes #331