Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monetary price and currency #640

Merged
merged 7 commits into from
Jan 14, 2021
Merged

Add monetary price and currency #640

merged 7 commits into from
Jan 14, 2021

Conversation

jannahastings
Copy link
Contributor

Add 'monetary price' and 'currency' with the definitions 'A monetary price is a quantity value that describes the amount of money requested, expected, required or given in exchange for something else.' and 'A unit which is a measure of the medium of an exchange value, defined by reference to the geographical location of the monetary authorities responsible for it.' respectively as per the FIBO sheet.

Closes #331

@github-actions github-actions bot added the oeo-social changes the oeo-social module label Jan 12, 2021
@akleinau
Copy link
Contributor

About the definition of monetary price: A monetary price is more concretely an economic value, quantity value is the superclass of economic value.

@jannahastings
Copy link
Contributor Author

About the definition of monetary price: A monetary price is more concretely an economic value, quantity value is the superclass of economic value.

Good catch. Now fixed in definition.

Copy link
Contributor

@sfluegel05 sfluegel05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added a FIBO-reference for currency, but not for monetary price (https://spec.edmcouncil.org/fibo/ontology/FND/Accounting/CurrencyAmount/Price).

Also, could you update the changelog for this pr and the others as well?

@jannahastings
Copy link
Contributor Author

You added a FIBO-reference for currency, but not for monetary price (https://spec.edmcouncil.org/fibo/ontology/FND/Accounting/CurrencyAmount/Price).

Reference now added.

Also, could you update the changelog for this pr and the others as well?

Changelog now updated.

Copy link
Contributor

@sfluegel05 sfluegel05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything looks fine to me. Thanks for implementing!

@jannahastings jannahastings merged commit 9f763a1 into dev Jan 14, 2021
@sfluegel05 sfluegel05 deleted the feature/price-#331 branch January 15, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-social changes the oeo-social module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should add the term price to oeo-social
3 participants