Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spatial regions #585

Merged
merged 8 commits into from
Oct 30, 2020
Merged

add spatial regions #585

merged 8 commits into from
Oct 30, 2020

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Oct 30, 2020

closes #475

  • A subregion is a spatial region that is a part of spatial region.
  • A study subregion is a subregion of a study region. ( = subregion of a study region)
  • A considered region region is a spatial region that is used in an analysis.
  • An interacting region is a spatial region that interacts with a red region. It is part of a considered region, but not a study region. Alternative term: external region
  • A study region is a spatial region that is under investigation and consists entirely of one or more subregions.

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-shared changes the oeo-shared module labels Oct 30, 2020
@l-emele
Copy link
Contributor

l-emele commented Oct 30, 2020

Are you still working on this or is it ready for review?

@stap-m
Copy link
Contributor Author

stap-m commented Oct 30, 2020 •
edited
Loading

I'm still working on an example...

edit: I comitted. Pleade review the example. When it is agreed on, I'd propose to copy it to the other spatial regions implemented here, too.

@l-emele
Copy link
Contributor

l-emele commented Oct 30, 2020

I am fine with the example. And fixed a small typo.

@stap-m stap-m merged commit d3d3252 into dev Oct 30, 2020
@stap-m stap-m deleted the feature/spatial-regions-#475 branch October 30, 2020 12:51
@stap-m stap-m restored the feature/spatial-regions-#475 branch October 30, 2020 12:52
stap-m pushed a commit that referenced this pull request Oct 30, 2020
include examples of usage for spatial regions, according PR #585
3e21df1
@MGlauer MGlauer deleted the feature/spatial-regions-#475 branch December 9, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-emele l-emele l-emele left review comments

@christian-rli christian-rli christian-rli approved these changes

@Vera-IER Vera-IER Awaiting requested review from Vera-IER

Assignees
No one assigned
Labels
oeo-model changes the oeo-model module oeo-shared changes the oeo-shared module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include terms covering the spatial regions of the scenario analysis space
3 participants
@stap-m @l-emele @christian-rli