-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update PortionOfMatter definitions #290
Conversation
maybe we should leave Ocean and Wave for now because I don't think they are good PortionOfMatter subclasses. |
Some proposals:
|
than there are just missing: I'll make this a "real" pull request so the other adapted definitions can be reviewed too. |
src/ontology/edits/oeo-physical.omn
Outdated
@@ -718,7 +718,7 @@ Biofuels can be derived directly from plants (i.e. energy crops), or indirectly | |||
Class: Biogas | |||
|
|||
Annotations: | |||
<http://purl.obolibrary.org/obo/IAO_0000115> "A gas composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.", | |||
<http://purl.obolibrary.org/obo/IAO_0000115> "Biogas is a portion of matter which has a gaseous state and is composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<http://purl.obolibrary.org/obo/IAO_0000115> "Biogas is a portion of matter which has a gaseous state and is composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.", | |
<http://purl.obolibrary.org/obo/IAO_0000115> "Biogas is a gaseous biofuel and is composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as charcoal, biogas is primarily a subclass of portion of matter. Would it be enough to add another sentence like "It is used as a fuel" at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, for biogas it could make sense to make it a direct subclass of biofuel. I think the term is primarily used in the fuel context, unlike e.g. methane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok it is now a direct subclass of Biofuel with the corresponding definition
src/ontology/edits/oeo-physical.omn
Outdated
@@ -810,7 +810,7 @@ Class: CarbonDioxideEmission | |||
Class: Charcoal | |||
|
|||
Annotations: | |||
<http://purl.obolibrary.org/obo/IAO_0000115> "The solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en, | |||
<http://purl.obolibrary.org/obo/IAO_0000115> "Charcoal is a portion of matter consisting of the solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<http://purl.obolibrary.org/obo/IAO_0000115> "Charcoal is a portion of matter consisting of the solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en, | |
<http://purl.obolibrary.org/obo/IAO_0000115> "Charcoal is a fuel consisting of the solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Charcoal is primarily a subclass of portion of matter. Would it be enough to add another sentence like "It is used as a fuel" at the end?
Co-Authored-By: l-emele <[email protected]>
I updated the definitions in a way that they are coherent with the asserted hierarchy. I added the use as fuel as another sentence like I wrote with charcoal and biogas, also for the new definitions of @l-emele. That way the definitions follow the asserted view but also incorporate the inferred view with the new fuel hierarchy. |
OilAndPetroleumProducts: "OilAndPetroleumProducts are portions of matter derived from crude oil (petroleum) as it is processed in oil refineries." (source: https://en.wikipedia.org/wiki/Petroleum_product) |
closes #280.
Makes PortionOfMatter subclass definitions aristotelean.
The following classes remain after I updated the definitions because there whole defs need a rework:
LiquidBiofuel
ManufacturedCoalBasedGas
CollieryGas
OilAndPetroleumProducts
GasDieselOil
Perfluorocarbon
DamnedWater
Ocean
PumpedWater
Wave