Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PortionOfMatter definitions #290

Merged
merged 6 commits into from
Mar 30, 2020
Merged

update PortionOfMatter definitions #290

merged 6 commits into from
Mar 30, 2020

Conversation

akleinau
Copy link
Contributor

closes #280.
Makes PortionOfMatter subclass definitions aristotelean.
The following classes remain after I updated the definitions because there whole defs need a rework:
LiquidBiofuel
ManufacturedCoalBasedGas
CollieryGas
OilAndPetroleumProducts
GasDieselOil
Perfluorocarbon
DamnedWater
Ocean
PumpedWater
Wave

@akleinau
Copy link
Contributor Author

@stap-m, @l-emele can you help create those defs?

@akleinau
Copy link
Contributor Author

maybe we should leave Ocean and Wave for now because I don't think they are good PortionOfMatter subclasses.

@l-emele
Copy link
Contributor

l-emele commented Mar 24, 2020

Some proposals:

  • A liquid biofuel is a biofuel that has normal state of matter liquid.
  • A manufactured coal based gas is a gaseous fossil fuel that is manufactured from coal.
  • Perfluorocarbons (PFCs) are portions of matter consisting of organic compounds that contain fluorine atoms but no hydrogen atoms. This is in line with the HFC definition. Do we already have the concept organic in the OEO? If not, could we import that from ChEBI? @jannahastings
  • Colliery gas is a fossil gaseous fuel found in coal mines (British English: colliery). The main component is methane. Synonyms are firedamp, mine gas.
  • Pumped water is water which was pumped into an upper reservoir and thus contains potential energy.

@akleinau
Copy link
Contributor Author

than there are just missing:
GasDieselOil
OilAndPetroleumProducts
DamnedWater

I'll make this a "real" pull request so the other adapted definitions can be reviewed too.

@akleinau akleinau marked this pull request as ready for review March 24, 2020 13:15
@@ -718,7 +718,7 @@ Biofuels can be derived directly from plants (i.e. energy crops), or indirectly
Class: Biogas

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "A gas composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.",
<http://purl.obolibrary.org/obo/IAO_0000115> "Biogas is a portion of matter which has a gaseous state and is composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<http://purl.obolibrary.org/obo/IAO_0000115> "Biogas is a portion of matter which has a gaseous state and is composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.",
<http://purl.obolibrary.org/obo/IAO_0000115> "Biogas is a gaseous biofuel and is composed principally of methane and carbon dioxide produced by anaerobic digestion of biomass.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as charcoal, biogas is primarily a subclass of portion of matter. Would it be enough to add another sentence like "It is used as a fuel" at the end?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, for biogas it could make sense to make it a direct subclass of biofuel. I think the term is primarily used in the fuel context, unlike e.g. methane.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok it is now a direct subclass of Biofuel with the corresponding definition

@@ -810,7 +810,7 @@ Class: CarbonDioxideEmission
Class: Charcoal

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "The solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en,
<http://purl.obolibrary.org/obo/IAO_0000115> "Charcoal is a portion of matter consisting of the solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<http://purl.obolibrary.org/obo/IAO_0000115> "Charcoal is a portion of matter consisting of the solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en,
<http://purl.obolibrary.org/obo/IAO_0000115> "Charcoal is a fuel consisting of the solid residue of the destructive distillation and pyrolysis of wood and other vegetal material."@en,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charcoal is primarily a subclass of portion of matter. Would it be enough to add another sentence like "It is used as a fuel" at the end?

@akleinau
Copy link
Contributor Author

I updated the definitions in a way that they are coherent with the asserted hierarchy. I added the use as fuel as another sentence like I wrote with charcoal and biogas, also for the new definitions of @l-emele. That way the definitions follow the asserted view but also incorporate the inferred view with the new fuel hierarchy.

@akleinau akleinau requested a review from stap-m March 25, 2020 12:51
@akleinau
Copy link
Contributor Author

akleinau commented Mar 26, 2020

OilAndPetroleumProducts: "OilAndPetroleumProducts are portions of matter derived from crude oil (petroleum) as it is processed in oil refineries." (source: https://en.wikipedia.org/wiki/Petroleum_product)
DamnedWater: "Damned water is water stopped by dams from flowing and thus contains energy useable for hydropower."

@akleinau akleinau merged commit a895470 into dev Mar 30, 2020
@akleinau akleinau deleted the feature/matterDefs-#280 branch March 30, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update definitions of subclasses of portion of matter
3 participants