Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model system boundary #1951 #1977

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

LillyG901
Copy link
Contributor

@LillyG901 LillyG901 commented Nov 24, 2024

Summary of the discussion

See #1951

Type of change (CHANGELOG.md)

Add

  • model system boundary

Workflow checklist

Automation

Closes #1951

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-model changes the oeo-model module label Nov 24, 2024
@LillyG901 LillyG901 marked this pull request as ready for review November 24, 2024 15:09
CHANGELOG.md Outdated Show resolved Hide resolved
Class: OEO_00400041

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "A model system boundary is a model component that separates aspects of the real world that are included in the model from those that are not.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how firmly the wording was agreed on but I think

"...aspects of the real world included in the model" would sound better than using "that" twice in a row.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@madbkr madbkr changed the title Add model system boundary Add model system boundary #1951 Nov 25, 2024
Co-authored-by: madbkr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

Add model system boundary
3 participants