-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add industrial technology
and industrial plant
#1840
Conversation
What is the state of this PR? Can you finish it until the release @l-emele? |
I don't think so. My implementation has led to some inconsistencies (see failing CI run). The problem is that classes introduced at different stages do not align, see issue discussion. I don't see a quick fix for this. |
I implemented the However, I want to discuss some further things related to the industry classes, see issue #1726. |
src/ontology/edits/oeo-physical.omn
Outdated
@@ -12618,6 +12648,8 @@ Class: OEO_00240026 | |||
|
|||
Annotations: | |||
<http://purl.obolibrary.org/obo/IAO_0000115> "An industrial material is a portion of matter that is the physical output of an industrial process and that has a good role."@en, | |||
<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/1053 | |||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1082", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR #1082 it was missed to add the term tracker for this class.
@stap-m : I think I've implemented everything as discussed today. So this PR is now (again) ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some minor things.
Summary of the discussion
Improve depiction of industry by adding
industrial technology
andindustrial plant
.Type of change (CHANGELOG.md)
Add
manufacturing technology
: A manufacturing technology is a technology that describes how to combine manufactuing plants and manufacturing processes to produce industrial materials.industrial technology
'is about' some ('manufacturing plant' and ('participates in' some ('manufacturing process' and ('has physical output' some 'manufactured material'))))
manufacturing plant
: A manufacturing plant is an artificial object that applies one or more manufacturing processes to produce one more kinds of industrial materials.industrial plant
manufactured commodity
: A manufactured commodity is a portion of matter that is the physical output of a manufacturing process and that has a commodity role.industrial commodity
'portion of matter' and ('physical output of' some 'manufacturing process') and ('has role' some 'commodity role')
Update
industrial material
->manufactured material
: A manufactured material is a portion of matter that is the physical output of a manufacturing process and that has a good role.'portion of matter' and ('physical output of' some 'manufacturing process') and ('has role' some 'good role')
Workflow checklist
Automation
Closes #1726
PR-Assignee
term tracker item
Reviewer