Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add industrial technology and industrial plant #1840

Merged
merged 17 commits into from
Aug 26, 2024

Conversation

l-emele
Copy link
Contributor

@l-emele l-emele commented Apr 19, 2024

Summary of the discussion

Improve depiction of industry by adding industrial technology and industrial plant.

Type of change (CHANGELOG.md)

Add

  • manufacturing technology: A manufacturing technology is a technology that describes how to combine manufactuing plants and manufacturing processes to produce industrial materials.
    • alternative label: industrial technology
    • axiom: 'is about' some ('manufacturing plant' and ('participates in' some ('manufacturing process' and ('has physical output' some 'manufactured material'))))
  • manufacturing plant: A manufacturing plant is an artificial object that applies one or more manufacturing processes to produce one more kinds of industrial materials.
    • alternative term: industrial plant
  • manufactured commodity: A manufactured commodity is a portion of matter that is the physical output of a manufacturing process and that has a commodity role.
    • alternative label: industrial commodity
    • axiom: 'portion of matter' and ('physical output of' some 'manufacturing process') and ('has role' some 'commodity role')

Update

  • industrial material -> manufactured material: A manufactured material is a portion of matter that is the physical output of a manufacturing process and that has a good role.
    • 'portion of matter' and ('physical output of' some 'manufacturing process') and ('has role' some 'good role')

Workflow checklist

Automation

Closes #1726

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Apr 19, 2024
@stap-m
Copy link
Contributor

stap-m commented May 2, 2024

What is the state of this PR? Can you finish it until the release @l-emele?

@l-emele
Copy link
Contributor Author

l-emele commented May 6, 2024

What is the state of this PR? Can you finish it until the release @l-emele?

I don't think so. My implementation has led to some inconsistencies (see failing CI run). The problem is that classes introduced at different stages do not align, see issue discussion. I don't see a quick fix for this.

@l-emele
Copy link
Contributor Author

l-emele commented Jun 25, 2024

I implemented the industry technology axiom wrong and that is why the CI was failing. I fixed this and it is now working again.

However, I want to discuss some further things related to the industry classes, see issue #1726.

CHANGELOG.md Show resolved Hide resolved
@@ -12618,6 +12648,8 @@ Class: OEO_00240026

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "An industrial material is a portion of matter that is the physical output of an industrial process and that has a good role."@en,
<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/1053
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1082",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PR #1082 it was missed to add the term tracker for this class.

@l-emele l-emele marked this pull request as ready for review June 28, 2024 10:21
@l-emele l-emele requested a review from stap-m July 1, 2024 07:42
@l-emele
Copy link
Contributor Author

l-emele commented Aug 22, 2024

@stap-m : I think I've implemented everything as discussed today. So this PR is now (again) ready for review.

Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some minor things.

src/ontology/edits/oeo-physical.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Show resolved Hide resolved
@l-emele l-emele requested a review from stap-m August 26, 2024 07:38
@l-emele l-emele merged commit 55c8c92 into dev Aug 26, 2024
4 checks passed
@l-emele l-emele deleted the feature-1726-industrial-technology branch August 26, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-physical changes the oeo-physical module oeo-shared-axioms
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Structure industrial processes, facilities and technologies
2 participants