-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added language labels #1719
Added language labels #1719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
The merging caused some ugly conflicts in oeo-physical. I am trying to solve them now. |
<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/811 | ||
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/931", | ||
rdfs:label "solid combustion fuel"@en | ||
|
||
EquivalentTo: | ||
OEO_00000099 | ||
and (OEO_00000529 value OEO_00000390) | ||
|
||
SubClassOf: | ||
OEO_00000099 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR deletes the SubClassOf axioms of the class solid combustion fuel
(OEO_00010144)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I carefully checked all changes of this PR.
The PR unintentionally deletes the SubClassOf axioms of two classes, see comments at specific lines.
All other changes seem to be fine.
Resolving the merge conflicts is too much efforts. We'll redo this directly in the release branch. |
Summary of the discussion
Issue: #1516
Old PR: #1687
Type of change (CHANGELOG.md)
Updated