Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added language labels #1719

Closed
wants to merge 7 commits into from
Closed

Added language labels #1719

wants to merge 7 commits into from

Conversation

areleu
Copy link
Contributor

@areleu areleu commented Oct 13, 2023

Summary of the discussion

Issue: #1516

Old PR: #1687

Type of change (CHANGELOG.md)

Updated

  • Updated langauge labels in multiple modules.

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module labels Oct 13, 2023
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@stap-m
Copy link
Contributor

stap-m commented Oct 16, 2023

The merging caused some ugly conflicts in oeo-physical. I am trying to solve them now.

<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/811
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/931",
rdfs:label "solid combustion fuel"@en

EquivalentTo:
OEO_00000099
and (OEO_00000529 value OEO_00000390)

SubClassOf:
OEO_00000099
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR deletes the SubClassOf axioms of the class solid combustion fuel (OEO_00010144)

Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I carefully checked all changes of this PR.

The PR unintentionally deletes the SubClassOf axioms of two classes, see comments at specific lines.

All other changes seem to be fine.

@l-emele
Copy link
Contributor

l-emele commented Oct 24, 2023

Resolving the merge conflicts is too much efforts. We'll redo this directly in the release branch.

@l-emele l-emele closed this Oct 24, 2023
@stap-m stap-m deleted the features-1516-add-language-labels branch October 25, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants