Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scenario study subclasses #1640 #1711

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

viktorwichern
Copy link
Contributor

@viktorwichern viktorwichern commented Oct 4, 2023

Summary of the discussion

Describe the findings of the discussion in the issue or meeting.

2 new subclasses of scenario studies were added, and the definition and axiom of the study class was changed to include that studies are done methodologically.

Type of change (CHANGELOG.md)

Added

-scenario projection comparison
-model intercomparison study

Updated

-study

Workflow checklist

Automation

Closes #1640

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-shared changes the oeo-shared module labels Oct 4, 2023
@viktorwichern viktorwichern self-assigned this Oct 4, 2023
@viktorwichern viktorwichern marked this pull request as ready for review October 4, 2023 23:32
l-emele
l-emele previously requested changes Oct 5, 2023
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both new classes the SubClassOf axiom contains the full IRI:

    SubClassOf: 
        <http://openenergy-platform.org/ontology/oeo/oeo-model/OEO_00010252>

@stap-m: Is this a problem of wrong Protégé settings?

@stap-m
Copy link
Contributor

stap-m commented Oct 5, 2023

@stap-m: Is this a problem of wrong Protégé settings?

Not sure. In PR #1638 the Subclasses were added correctly. @viktorwichern did you change any preferences in protege since then?

EDIT:
If I change the subclass delarations, it causes an error.
Hence, I did some testing. I added a new test class to oeo-model myself and the same happens there. Whereas new test classes in oeo-physical, social or shared look normal.

grafik

grafik

@viktorwichern
Copy link
Contributor Author

EDIT: If I change the subclass delarations, it causes an error. Hence, I did some testing. I added a new test class to oeo-model myself and the same happens there. Whereas new test classes in oeo-physical, social or shared look normal.

That makes sense, I did not have this problem before while working on the other modules and I also did not change any preferences in Protege.

@stap-m
Copy link
Contributor

stap-m commented Oct 9, 2023

The class declarations are corrupt and therefore is the call of the classes. I will fix this in a separate PR, based on #1706

src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
@stap-m stap-m mentioned this pull request Oct 9, 2023
5 tasks
@viktorwichern viktorwichern merged commit 131e6a6 into dev Oct 9, 2023
@viktorwichern viktorwichern deleted the feature-1640-add-study-subclasses branch October 9, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-shared changes the oeo-shared module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add more study subclasses
3 participants