Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ptx technologies #1592 #1647

Merged
merged 8 commits into from
Sep 8, 2023
Merged

add ptx technologies #1592 #1647

merged 8 commits into from
Sep 8, 2023

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Sep 6, 2023 •
edited
Loading

Summary of the discussion

Add power-to-fuel technologies and subclasses, see #1572.

Type of change (CHANGELOG.md)

Added

  • power-to-fuel technology as subclass of energy technology
  • power-to-gas technology as subclass of power-to-x technology
  • power-to-ammonia technology as subclass of power-to-gas technology
  • power-to-methane technology as subclass of power-to-gas technology
  • power-to-liquid technology as subclass of power-to-x technology

Updated

  • Updated a definition #

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m self-assigned this Sep 6, 2023
@stap-m stap-m changed the title add ptx technology hierarchy #1592 add ptx technologies #1592 Sep 6, 2023
@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Sep 6, 2023
@stap-m stap-m marked this pull request as ready for review September 6, 2023 14:27
@stap-m stap-m requested a review from l-emele September 6, 2023 14:27
l-emele
l-emele approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@stap-m
Copy link
Contributor Author

stap-m commented Sep 7, 2023

Thanks. I just saw that the other technology subclasses do not have defined axioms. Hence, I changes the equivalences to "normal" axioms in tha latest commit. Can you check again please @l-emele ?

l-emele
l-emele approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks still looks fine after the latest commit.

@stap-m stap-m merged commit 986c0bd into dev Sep 8, 2023
@stap-m stap-m deleted the feature-1572-ptx-technologies branch September 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-emele l-emele l-emele approved these changes

Assignees

@stap-m stap-m

Labels
oeo-physical changes the oeo-physical module
Projects
Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stap-m @l-emele