-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1430: Remove non simple property restrictions #1479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on #1475 |
areleu
changed the title
1430: Remove non simple properties
1430: Remove non simple property restrictions
Feb 14, 2023
l-emele
reviewed
Feb 15, 2023
CHANGELOG.md
Outdated
### Changed | ||
- changed order in which the oeo-full files are compiled, owl now builds before omn. | ||
- updated part relation between electricity grid and power line to have simple restrictions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here only the class electricity grid
should be mentioned, without the details of the changes.
l-emele
reviewed
Feb 15, 2023
stap-m
requested changes
Mar 1, 2023
Co-authored-by: stap-m <[email protected]>
Co-authored-by: stap-m <[email protected]>
stap-m
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
Related to #1430, in order to have a valid DL profile we need to remove the
min 1
restriction. it was replaced with a simplesome
restrictionType of change (CHANGELOG.md)
Updated
Workflow checklist
Automation
Closes #
PR-Assignee
term tracker item
Reviewer