Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1430: Remove non simple property restrictions #1479

Merged
merged 17 commits into from
Mar 9, 2023

Conversation

areleu
Copy link
Contributor

@areleu areleu commented Feb 14, 2023

Summary of the discussion

Related to #1430, in order to have a valid DL profile we need to remove the min 1 restriction. it was replaced with a simple some restriction

Type of change (CHANGELOG.md)

Updated

  • updated part relation between electricity grid and power line to have simple restrictions.

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Feb 14, 2023
@areleu
Copy link
Contributor Author

areleu commented Feb 14, 2023

Depends on #1475

@areleu areleu changed the title 1430: Remove non simple properties 1430: Remove non simple property restrictions Feb 14, 2023
CHANGELOG.md Outdated
### Changed
- changed order in which the oeo-full files are compiled, owl now builds before omn.
- updated part relation between electricity grid and power line to have simple restrictions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here only the class electricity grid should be mentioned, without the details of the changes.

CHANGELOG.md Outdated Show resolved Hide resolved
src/ontology/edits/oeo-shared.omn Show resolved Hide resolved
@areleu areleu merged commit 38c3269 into dev Mar 9, 2023
@stap-m stap-m deleted the fix-1430-remove-non-simple-properties branch October 25, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared changes the oeo-shared module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants