Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced owl:equivalentClass with may be identical to in Annotations #1464

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Replaced owl:equivalentClass with may be identical to in Annotations #1464

merged 3 commits into from
Feb 1, 2023

Conversation

areleu
Copy link
Contributor

@areleu areleu commented Feb 1, 2023

Summary of the discussion

Part of issue #1430

Type of change (CHANGELOG.md)

Updated

  • Annotation properties relating to classes in external ontologies now are may be identical to instead of owl:equivalentClass

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module labels Feb 1, 2023
@areleu areleu added this to the oeo-release-1.13.0 milestone Feb 1, 2023
l-emele
l-emele requested changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments:

  • owl:equivalentClass is not used anymore, so please deleted the lines
AnnotationProperty: owl:equivalentClass

from oeo-shared, oeo-model and oeo-physical.

  • Please document the changes in CHANGELOG.md. Something like replace owl:equivalentClass with 'may be identical to'

@github-actions github-actions bot added the oeo-model changes the oeo-model module label Feb 1, 2023
l-emele
l-emele approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now

u-mueller
u-mueller approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@u-mueller u-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me, too.

@areleu areleu merged commit ba78849 into dev Feb 1, 2023
@areleu areleu deleted the fix-1430-equivalent-class-annotations branch February 1, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u-mueller u-mueller u-mueller approved these changes

@l-emele l-emele l-emele approved these changes

@fabianneuhaus fabianneuhaus Awaiting requested review from fabianneuhaus

@stap-m stap-m Awaiting requested review from stap-m

Assignees
No one assigned
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module
Projects
None yet
Milestone
oeo-release-1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@areleu @l-emele @u-mueller