-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export of existing terms and definitions #1020 #1319
Export of existing terms and definitions #1020 #1319
Conversation
Thanks for the script @stage1407 |
Last adaptions
Yes, I have added this information. |
The python script is missing a requirements.txt this should include both pandas, openpyxl and tabulate. I would say that this requirements.txt should include also the dependencies of the rest of the scripts. There is an issue with some terms appearing as IRIs. I think having all the term appearing as IRIs would be nice. Like making them into a link like: |
Looks great, thanks! @areleu Once we agreed on a final place (I like the idea of storing it in the wiki), we should also adjust the respective README.md and maybe link the glorrary to the main README.md, too. |
A while ago, we discussed in the OEO Dev meeting, that this should be part of the release cycle:
Originally posted by @l-emele in #1020 (comment) So it should be not only in the wiki, but also part of the files that is transferred to the OEP after release. If I remember correctly, the OEP is able to render markdown files. Is that right, @wingechr ? |
On one hand, I like having the the possibility to jump to a specific letter. But if I see correctly, there are now multiple markdown files. But the original idea was to export all definitions to one single file for easy for facilitate simple re-use. |
I don't think these have mutually exclusive. We can use the same script to generate a csv file on the side. The reason I divided it in different pages was that It seems that GitHub has a limit on the page height and it was being cut. |
Okay then. I just wanted to avoid that we create a solution, that does not solve the original problem, ;) |
I put this PR on the agenda for the next dev meeting to finalize it. |
I added the changes we agreed on the last dev meeting. I will also add the option to upload a csv file with the list. I would like to know how can I integrate this into the OEP, is there a way to upload this with the API? |
The existing terms and definitions are there as a table availible. We can output markdown and csv files. The open question is where this information should be made availible. Directly in the OEP? if so. How can this be made and where? Independently of this, I think this PR can be merged as it does not break anything and any further changes needed for the OEP integration can be worked in a new one. |
I think having both a markdown and a csv file to download on the OEP is fine as these target different users. The markdown file can probably also be rendered directly on the OEP. EDIT: I opened an issue in the OEP repo: OpenEnergyPlatform/oeplatform#1123 |
@stap-m If you look at the bottom of the job summary there is an optiion to download a zip file with the contents of the tables: https://github.com/OpenEnergyPlatform/ontology/actions/runs/3713531310 Let me know if there is anything critical to change, otherwise I will just merge it. |
Looks fine from my side! |
Summary of the discussion
Create a script that writes an auto-generated glossary in a markdown table.
Type of change (CHANGELOG.md)
Added
Workflow checklist
Automation
Closes #
PR-Assignee
term tracker item
Reviewer