Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export of existing terms and definitions #1020 #1319

Merged
merged 36 commits into from
Dec 19, 2022

Conversation

stage1407
Copy link
Contributor

@stage1407 stage1407 commented Oct 3, 2022

Summary of the discussion

Create a script that writes an auto-generated glossary in a markdown table.

Type of change (CHANGELOG.md)

Added

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stage1407 stage1407 added meta issue Issue that collects information about topics and will be closed after detailled issues are solved. ontology infrastructure labels Oct 3, 2022
@stage1407 stage1407 added this to the oeo-release-1.13.0 milestone Oct 3, 2022
@stage1407 stage1407 marked this pull request as ready for review October 3, 2022 15:06
@stage1407 stage1407 removed the meta issue Issue that collects information about topics and will be closed after detailled issues are solved. label Oct 3, 2022
@stap-m
Copy link
Contributor

stap-m commented Oct 4, 2022

Thanks for the script @stage1407
Could you please add information (to the README?), where the glossary be accessible?
Will the glossary be updated (automaticcaly), when there's a new release?

Last adaptions
@stage1407
Copy link
Contributor Author

stage1407 commented Oct 4, 2022

Yes, I have added this information.
No, this has to be done manually in the terminal so far. But if this is to be automatic, then someone more familiar with the Makefile should implement this procedure. It should be nothing more than adding the command to the Makefile, but I don't know where in the Makefile. I think a new issue should be started for this one.

@stap-m stap-m requested a review from areleu October 6, 2022 09:06
@areleu
Copy link
Contributor

areleu commented Oct 7, 2022

The python script is missing a requirements.txt this should include both pandas, openpyxl and tabulate. I would say that this requirements.txt should include also the dependencies of the rest of the scripts.
I had to do some adjustments to be able to run it on windows but these are not critical as we are building this in github aren't we?

There is an issue with some terms appearing as IRIs. I think having all the term appearing as IRIs would be nice. Like making them into a link like:

OEO:00010252

@stap-m
Copy link
Contributor

stap-m commented Oct 10, 2022

Looks great, thanks! @areleu
@stage1407 and @carstenhoyerklick can you please take a look?

Once we agreed on a final place (I like the idea of storing it in the wiki), we should also adjust the respective README.md and maybe link the glorrary to the main README.md, too.
EDIT: And if it stays in the wiki, update wiki sidebar.

@l-emele
Copy link
Contributor

l-emele commented Oct 10, 2022

Once we agreed on a final place (I like the idea of storing it in the wiki), we should also adjust the respective README.md and maybe link the glorrary to the main README.md, too.

A while ago, we discussed in the OEO Dev meeting, that this should be part of the release cycle:

We discussed today at the OEO DEV meeting, that it would be also nice, to produce such a file during the release process. On option would to be to export a list of IDs, labels (terms) and definitions to an markdown file that is then part of the repo.

Originally posted by @l-emele in #1020 (comment)

So it should be not only in the wiki, but also part of the files that is transferred to the OEP after release.

If I remember correctly, the OEP is able to render markdown files. Is that right, @wingechr ?

@l-emele
Copy link
Contributor

l-emele commented Oct 10, 2022

On one hand, I like having the the possibility to jump to a specific letter. But if I see correctly, there are now multiple markdown files. But the original idea was to export all definitions to one single file for easy for facilitate simple re-use.

@areleu
Copy link
Contributor

areleu commented Oct 10, 2022

On one hand, I like having the the possibility to jump to a specific letter. But if I see correctly, there are now multiple markdown files. But the original idea was to export all definitions to one single file for easy for facilitate simple re-use.

I don't think these have mutually exclusive. We can use the same script to generate a csv file on the side. The reason I divided it in different pages was that It seems that GitHub has a limit on the page height and it was being cut.

@l-emele
Copy link
Contributor

l-emele commented Oct 10, 2022

Okay then. I just wanted to avoid that we create a solution, that does not solve the original problem, ;)

@stap-m
Copy link
Contributor

stap-m commented Oct 14, 2022

I put this PR on the agenda for the next dev meeting to finalize it.

@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Oct 28, 2022
@areleu
Copy link
Contributor

areleu commented Oct 31, 2022

I added the changes we agreed on the last dev meeting. I will also add the option to upload a csv file with the list. I would like to know how can I integrate this into the OEP, is there a way to upload this with the API?

@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Nov 24, 2022
@areleu
Copy link
Contributor

areleu commented Dec 1, 2022

The existing terms and definitions are there as a table availible. We can output markdown and csv files. The open question is where this information should be made availible. Directly in the OEP? if so. How can this be made and where?

Independently of this, I think this PR can be merged as it does not break anything and any further changes needed for the OEP integration can be worked in a new one.

@l-emele
Copy link
Contributor

l-emele commented Dec 1, 2022

I think having both a markdown and a csv file to download on the OEP is fine as these target different users. The markdown file can probably also be rendered directly on the OEP.

EDIT: I opened an issue in the OEP repo: OpenEnergyPlatform/oeplatform#1123

@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Dec 16, 2022
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Dec 16, 2022
@areleu
Copy link
Contributor

areleu commented Dec 16, 2022

@stap-m If you look at the bottom of the job summary there is an optiion to download a zip file with the contents of the tables:

https://github.com/OpenEnergyPlatform/ontology/actions/runs/3713531310

Let me know if there is anything critical to change, otherwise I will just merge it.

@stap-m
Copy link
Contributor

stap-m commented Dec 19, 2022

Looks fine from my side!

@areleu areleu merged commit 15a8b13 into dev Dec 19, 2022
@stap-m stap-m deleted the feature-1020-export-of-existing-terms-and-definitions branch October 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-physical changes the oeo-physical module ontology infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants