Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term "market revenue" #908

Closed
5 tasks
han-f opened this issue Oct 12, 2021 · 7 comments · Fixed by #929
Closed
5 tasks

Add term "market revenue" #908

han-f opened this issue Oct 12, 2021 · 7 comments · Fixed by #929
Assignees
Labels
[A] new term Including new term(s) in the ontology ready for implementation

Comments

@han-f
Copy link
Contributor

han-f commented Oct 12, 2021

Description of the issue

identified in #839

Ideas of solution

market revenue is income from trading at markets

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@han-f han-f added [A] new term Including new term(s) in the ontology To do Issues that haven't got discussed yet labels Oct 12, 2021
@stap-m
Copy link
Contributor

stap-m commented Oct 26, 2021

We could classify it as economic value, or is there a subclass that would be even more suitable @han-f ? income is not (yet) part of the OEO...

@han-f
Copy link
Contributor Author

han-f commented Oct 26, 2021

I think economic value could work for now.

Income in FIBO is: revenue received during a period of time
https://spec.edmcouncil.org/fibo/ontology/FND/Accounting/AccountingEquity/Income

@l-emele
Copy link
Contributor

l-emele commented Oct 26, 2021

Maybe we should distinguish between two different concepts:

  • The process of getting some money from the market, so a special kind of more generic money transfer process (which we currently do not have).
  • A quantity value associated to that process.

But maybe I am just thinking too complicated.

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Oct 26, 2021
@stap-m
Copy link
Contributor

stap-m commented Oct 28, 2021

I don't think we need a money transfer process in the OEO.
FIBO's income def is recursive to our revenue proposal, so net really helpful.
If we just stayed with what we have, it would be:

Market revenue is an econimic value that represents the income from a trade at a market exchange.

@l-emele
Copy link
Contributor

l-emele commented Nov 2, 2021

That proposal sounds good from my non-economist view.

@l-emele l-emele added this to the oeo-release-1.8.0 milestone Nov 2, 2021
@han-f
Copy link
Contributor Author

han-f commented Nov 3, 2021

Just corrected typo compared to version above: Market revenue is an economic value that represents the income from a trade at a market exchange

@l-emele
Copy link
Contributor

l-emele commented Nov 3, 2021

So ready for implementation?

stap-m pushed a commit that referenced this issue Nov 4, 2021
stap-m pushed a commit that referenced this issue Nov 4, 2021
stap-m pushed a commit that referenced this issue Nov 4, 2021
stap-m added a commit that referenced this issue Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology ready for implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants