Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean object properties from restructuring #1703

Closed
5 tasks
stap-m opened this issue Sep 28, 2023 · 2 comments
Closed
5 tasks

clean object properties from restructuring #1703

stap-m opened this issue Sep 28, 2023 · 2 comments
Labels
[B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet
Milestone
oeo-release-2.0.0...

Comments

@stap-m
Copy link
Contributor

stap-m commented Sep 28, 2023

Description of the issue

related to #1592

After the restructuring and the huge PR #1652, the object properties in oeo-shared need to be reviewed.

Ideas of solution

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@stap-m stap-m added [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Sep 28, 2023
@stap-m
Copy link
Contributor Author

stap-m commented Sep 29, 2023 •
edited
Loading

I think it is sensible to clean the object properties now, before doing anything else for the restructuring, to get a clean dev branch again.
EDIT: we will probably have to do that again after populating oeo-sector, but I think it might be worthwile to do it now anyway.

@stap-m
Copy link
Contributor Author

stap-m commented Sep 29, 2023

Step 1 would be to go through oeo-shared, look at the class remainders and check the object properties used, if they should be moved to another module for their domain and range.
Step 2 would be to check the other modules afterwards for remainders.

stap-m added a commit that referenced this issue Sep 29, 2023
@stap-m
move has global warming potential to oeo-physical #1703
51abbdc
@stap-m stap-m mentioned this issue Sep 29, 2023
Merged
5 tasks
stap-m added a commit that referenced this issue Sep 29, 2023
@stap-m
move has energy input to oeo-physical #1703
6811435
stap-m added a commit that referenced this issue Sep 29, 2023
@stap-m
move has energy output to oeo-physical #1703
c3fa50d
stap-m added a commit that referenced this issue Sep 29, 2023
@stap-m
move has energy participant to oeo-physical #1703
1218d12
stap-m added a commit that referenced this issue Sep 29, 2023
@stap-m
move is energy participant of oeo-physical #1703
85243d0
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
clean has organisation #1703
8ac2b7d
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
clean has #1703
512e6e6
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
clean has client #1703
13b8023
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
clean has author #1703
25fc17d
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
clean has contributor #1703
7fc2a63
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
clean models #1703
a103ab4
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
clean has organization #1703
bf42399
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
move axiom of organization #1703
2b13751
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
remove remnant class and property declarations from shared #1703
99819ef
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
remove doubled axioms from oeo-shared-axioms #1703
e263bc8
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
remove doubled axioms from oeo-shared-axioms #1703
25a75c1
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
remove doubled axioms from oeo-shared-axioms #1703
35b3736
stap-m added a commit that referenced this issue Oct 2, 2023
@stap-m
remove doubled axioms from oeo-shared-axioms #1703
b4e541a
This was referenced Oct 4, 2023
Merged
Merged
stap-m added a commit that referenced this issue Oct 10, 2023
@stap-m
Merge pull request #1706 from OpenEnergyPlatform/feature-1703-clean-o…
cdade29 
…bject-properties

move object properties from shared to original modules #1703
@stap-m stap-m closed this as completed Oct 10, 2023
@stap-m stap-m mentioned this issue Oct 12, 2023
Closed
5 tasks
@github-project-automation github-project-automation bot moved this to Done in Issues Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet
Projects
Issues
Status: Done
Milestone
oeo-release-2.0.0-restructuring
Development

No branches or pull requests
1 participant
@stap-m