Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module for sectors? #1399

Closed
5 tasks
l-emele opened this issue Nov 16, 2022 · 7 comments
Closed
5 tasks

New module for sectors? #1399

l-emele opened this issue Nov 16, 2022 · 7 comments
Assignees
Labels
[B] restructure Restructuring existing parts of the ontology oeo dev meeting Discuss issue at oeo dev meeting ontology infrastructure ready for implementation

Comments

@l-emele
Copy link
Contributor

l-emele commented Nov 16, 2022

Description of the issue

We currently have 14 sector classes with 100 individuals, two sector division classes with nine individuals and one specific object property is sector of. The list of sector individuals might grow significantly further as we not even have included all CRF sectors.

It might be a good idea to create a separate module for sectors and related concepts. Then, and OEO user who is not interested in sector can decide not to use the sector module and does not see all those many individuals.

Ideas of solution

New parallel module

The most obvious solution would be to create an oeo-sectors module that sits parallel to the other modules:

                    oeo-shared
        /        /             \        \
oeo-model   oeo-physical   oeo-social   oeo-sectors

New module below the others

A second option would be, that the oeo-sectors module is below all the other modules, i.e. imports all of them:

             oeo-shared
        /        |         \
oeo-model   oeo-physical   oeo-social
        \        |         /
            oeo-sectors

This has the advantage, that all is sector of axioms can be included in the proposed oeo-sectors module. In the first option, these axioms have to be in oeo-shared.

And we might even shift back some classes from oeo-shared to their modules. E.g. mineral oil refining process was recently (PR #1390) moved to oeo-shared, because of the is sector of axiom.

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@l-emele l-emele added [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Nov 16, 2022
@l-emele l-emele self-assigned this Nov 16, 2022
@l-emele l-emele added this to the oeo-release-1.14.0 milestone Nov 16, 2022
@l-emele l-emele added the oeo dev meeting Discuss issue at oeo dev meeting label Nov 16, 2022
@stap-m
Copy link
Contributor

stap-m commented Nov 16, 2022

Good point.
With the growing shared-module and the problems of PR #870, we shloud take a look at the whole modular stucture.

@l-emele
Copy link
Contributor Author

l-emele commented Nov 16, 2022

I've put it on the agenda for the oeo dev meeting 49, which is on 1 December.
https://etherpad.wikimedia.org/p/oeo-dev-49
Feel free to add there!

@l-emele
Copy link
Contributor Author

l-emele commented Dec 1, 2022

In OEO dev meeting 49 we discussed this issue. If we keep the general structure with topic modules, a separate sectors modules definitely makes sense. But even if we abolish the general topic modules, we might still add a sectors module.

One option which is independent from the decision on the general structure is to transfer only the sector (and sector division) individuals to a separate module.

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Dec 1, 2022
@l-emele
Copy link
Contributor Author

l-emele commented Sep 13, 2023

I moved this issue to the release milestone 2.0.0. We should decide, whether we introduce this new module for the 2.0.0 release.

@l-emele
Copy link
Contributor Author

l-emele commented Sep 21, 2023

Discussed in OEO dev meeting 66: Create sector module as proposed in issue #1592 that contains both sector classes and sector individuals. Most axioms will be in oeo-shared-axioms. If latter becomes too large, we might introduce a separate shared-axioms file only for the sector axioms.
grafik

EDIT: Implementation of the sector module starts only after the large restructuring of PR #1652 is merged.

@stap-m
Copy link
Contributor

stap-m commented Sep 29, 2023

I'll start with the implementation.

stap-m added a commit that referenced this issue Sep 29, 2023
@stap-m stap-m mentioned this issue Sep 29, 2023
8 tasks
stap-m added a commit that referenced this issue Oct 17, 2023
stap-m added a commit that referenced this issue Oct 20, 2023
stap-m added a commit that referenced this issue Oct 20, 2023
stap-m added a commit that referenced this issue Oct 20, 2023
stap-m added a commit that referenced this issue Oct 20, 2023
@l-emele
Copy link
Contributor Author

l-emele commented Oct 24, 2023

I close this now as we will be releasing the new structure in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology oeo dev meeting Discuss issue at oeo dev meeting ontology infrastructure ready for implementation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants