-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module for sectors? #1399
Comments
Good point. |
I've put it on the agenda for the oeo dev meeting 49, which is on 1 December. |
In OEO dev meeting 49 we discussed this issue. If we keep the general structure with topic modules, a separate sectors modules definitely makes sense. But even if we abolish the general topic modules, we might still add a sectors module. One option which is independent from the decision on the general structure is to transfer only the sector (and sector division) individuals to a separate module. |
I moved this issue to the release milestone 2.0.0. We should decide, whether we introduce this new module for the 2.0.0 release. |
Discussed in OEO dev meeting 66: Create sector module as proposed in issue #1592 that contains both sector classes and sector individuals. Most axioms will be in oeo-shared-axioms. If latter becomes too large, we might introduce a separate shared-axioms file only for the sector axioms. EDIT: Implementation of the sector module starts only after the large restructuring of PR #1652 is merged. |
I'll start with the implementation. |
I close this now as we will be releasing the new structure in a few minutes. |
Description of the issue
We currently have 14
sector
classes with 100 individuals, twosector division
classes with nine individuals and one specific object propertyis sector of
. The list of sector individuals might grow significantly further as we not even have included all CRF sectors.It might be a good idea to create a separate module for sectors and related concepts. Then, and OEO user who is not interested in sector can decide not to use the sector module and does not see all those many individuals.
Ideas of solution
New parallel module
The most obvious solution would be to create an oeo-sectors module that sits parallel to the other modules:
New module below the others
A second option would be, that the oeo-sectors module is below all the other modules, i.e. imports all of them:
This has the advantage, that all
is sector of
axioms can be included in the proposed oeo-sectors module. In the first option, these axioms have to be in oeo-shared.And we might even shift back some classes from oeo-shared to their modules. E.g.
mineral oil refining process
was recently (PR #1390) moved to oeo-shared, because of theis sector of
axiom.Workflow checklist
I am aware that
The text was updated successfully, but these errors were encountered: