Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Technology subclasses needed? #136

Closed
6 tasks
akleinau opened this issue Nov 27, 2019 · 8 comments · Fixed by #273 or #334
Closed
6 tasks

Are Technology subclasses needed? #136

akleinau opened this issue Nov 27, 2019 · 8 comments · Fixed by #273 or #334
Assignees
Labels
[B] restructure Restructuring existing parts of the ontology oeo-physical changes the oeo-physical module

Comments

@akleinau
Copy link
Contributor

Description of the issue

Are subclasses of Technology like EnergyGeneratorTechnology or EnergyTransferTechnology needed? Or is just Technology enough?
@stap-m raised this question in #86.

Ideas of solution

Delete all subclasses?

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have an annotation
  • classes should arise from concepts rather than from words
  • class or property names should follow the UpperCamelCase
@akleinau akleinau added the [B] restructure Restructuring existing parts of the ontology label Nov 27, 2019
@akleinau
Copy link
Contributor Author

akleinau commented Mar 2, 2020

as discussed in february ontohack:

  • new Technology def: A Technology is an information content entity that specifies how to create an artificial object.
  • delete or move technology subclasses, depending on Restructure class Generator  #173

@akleinau
Copy link
Contributor Author

akleinau commented Apr 2, 2020

I forgot to change the def, pull request will follow soon

@akleinau akleinau reopened this Apr 2, 2020
@akleinau
Copy link
Contributor Author

akleinau commented Apr 2, 2020

@jannahastings if Technology is an information content entity this will move it to oeo-model, is that still in line with our modules?

@jannahastings
Copy link
Contributor

If we go with that definition, then the name should be changed to "technology specification" rather than just technology. But it does not have to move to oeo-model, as we can have information content entities in the other modules as well? I think, to me, it would make more sense to keep it in the oeo-physical...?

@l-emele l-emele added this to the oeo-release-0.0.1 milestone Apr 15, 2020
@akleinau
Copy link
Contributor Author

@jannahastings I agree, so how do we proceed, do we make a new module just for one class? that would seem wasteful. Copy and paste the class direcly inside oeo-physical?

@jannahastings
Copy link
Contributor

Both are possible, but I vote let's make a new module just for one class, it's not a big deal with robot and we may add more in the future. We could call it "iao-minimal"?

@akleinau
Copy link
Contributor Author

ok, then let's do that

@akleinau
Copy link
Contributor Author

I'll make a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology oeo-physical changes the oeo-physical module
Projects
None yet
3 participants