Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radiation receiving surface #1074

Closed
5 tasks done
carstenhoyerklick opened this issue Mar 11, 2022 · 17 comments · Fixed by #1228
Closed
5 tasks done

radiation receiving surface #1074

carstenhoyerklick opened this issue Mar 11, 2022 · 17 comments · Fixed by #1228
Labels
[A] new term Including new term(s) in the ontology ready for implementation

Comments

@carstenhoyerklick
Copy link
Contributor

carstenhoyerklick commented Mar 11, 2022

Description of the issue

For solar radation defintions we need a receiving surface, which can have different orientations. This issue is derived from #1031

Ideas of solution

As discussed in the OEO-DEV 33 meeting, we need a solar radation receiving surface to be able to annotate solar radation on horizontal, tilted, tracking, normal.... surfaces.

A first suggestion for a defintion:

"A solar radiation receiving surface is a plane surface which is receiving solar radiation. It can be fixed with the defined orientation or can be movable to e.g. follow the path of the sun"

It could go be a subclass of .... continuant->independent continuant -> material entity -> object -> artfical object

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@carstenhoyerklick carstenhoyerklick added [A] new term Including new term(s) in the ontology To do Issues that haven't got discussed yet labels Mar 11, 2022
@l-emele
Copy link
Contributor

l-emele commented Mar 15, 2022

I don't see, why a plane surface necessarily has to be an artificial object. I think it is better described as a two-dimensional region. Or are you looking for an umbrella term to solar thermal collector and PV cell?

@carstenhoyerklick
Copy link
Contributor Author

It it something like an umbrella termin for solar thermal collector, PV cell and measurement devices to measure solar radiation.

@l-emele
Copy link
Contributor

l-emele commented May 16, 2022

I suggest the following definition: A solar radiation receiving surface is an artificial object that is receiving solar energy via solar radiation. I suggest the following axioms:
'solar radiation receiving surface' 'Equivalent To' ('artificial object and 'has energy input' some 'solar energy')
'solar radiation receiving surface' 'participates in' some 'solar radiation'

Then, solar thermal collector, PV cell, solar power unit, PV panel and solar thermal power unit will be inferred as subclasses of solar radiation receiving surface.

Does that fit your purpose?

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label May 16, 2022
@stap-m
Copy link
Contributor

stap-m commented May 17, 2022

I like the proposal by @l-emele .

'solar radiation receiving surface' 'participates in' some 'solar radiation'

The solar radiation process doesn't necessarily involve any surfaces. Yet, its potential subclasses global radiation and direct normal radiation (#1076) may do.

@carstenhoyerklick
Copy link
Contributor Author

Yes, this sounds useful for me. I need it to define the orientation of solar radiation measurements. But we also need to be able to describe orientations of solar thermal collectors and PV cells and PV panels too.

@jannahastings
Copy link
Contributor

jannahastings commented May 20, 2022

After discussion of the definition of surface with @fabianneuhaus, we propose:

surface: defined A tangential proper part of an object that extends in two dimensions.

where tangential proper part is a subclass of fiat object part from BFO, and is from the Region connection calculus and means that the part is at the boundary of the object.

@l-emele
Copy link
Contributor

l-emele commented May 31, 2022

Okay, then I think this issue is ready for implementation.

@l-emele
Copy link
Contributor

l-emele commented Jun 15, 2022

Any reason why this issue is not yet implemented?

@stap-m
Copy link
Contributor

stap-m commented Jun 15, 2022

I can implement.

@stap-m
Copy link
Contributor

stap-m commented Jun 15, 2022

The proposed equivalent class
'solar radiation receiving surface' 'Equivalent To' ('artificial object and 'has energy input' some 'solar energy') isn't valid when we make surface a subclass of fiat object part...
The easiest would be to broaden the domain of has energy participant to material entity instead of only artificial object. Wold that break anything?

stap-m pushed a commit that referenced this issue Jun 15, 2022
@stap-m
Copy link
Contributor

stap-m commented Jun 17, 2022

Then, solar thermal collector, PV cell, solar power unit, PV panel and solar thermal power unit will be inferred as subclasses of solar radiation receiving surface.

Maybe because of being a surface instead of an artificial object now, this inference doesn't work.
We could add the axiom has part some solar receiving surface to these artifitial objects and then create another equivalent class with artificial object ans (has part some solar receiving surface). Is there a fancier way to create this umbrella class?

stap-m pushed a commit that referenced this issue Jun 17, 2022
@l-emele
Copy link
Contributor

l-emele commented Jun 20, 2022

Yes, I think, PV cell and solar thermal collector should get the axiom has part some solar receiving surface. Later, when we also have a solar measurement device, that should also get this axiom.

And I also think that an equivalent class artificial object ans (has part some solar receiving surface) is the right way to construct this umbrella class. The label could be something like a solar receiving object or solar receiver. @carstenhoyerklick : Any suggestion for a good label?

@carstenhoyerklick
Copy link
Contributor Author

I think solar receiving object would to. A 'solar receiver' is often something different. In concentrating solar power, the element which receives the concentrated radiation (a tube in a parablic trough collector) or a black element on top of a tower is the 'solar receiver'. This is in general something more specific, that our object here.

stap-m pushed a commit that referenced this issue Jun 23, 2022
stap-m pushed a commit that referenced this issue Jun 23, 2022
@stap-m
Copy link
Contributor

stap-m commented Jun 23, 2022

I add the following def to it A solar receiving object is an artificial object that has a solar radiation receiving surface as part. OK?

stap-m pushed a commit that referenced this issue Jun 23, 2022
stap-m pushed a commit that referenced this issue Jun 23, 2022
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
fixed edits via selective stagging

cherry-picked from  97a326f
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
cherry picked from commit 98a12f9
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
includes `term tracker item`

cherry picked from commit 98a12f9
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
cherry picked from commit c36791b
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
(cherry picked from commit c36791b)
markus-rothkoetter added a commit that referenced this issue Jun 24, 2022
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
markus-rothkoetter pushed a commit that referenced this issue Jun 24, 2022
markus-rothkoetter added a commit that referenced this issue Jun 28, 2022
Change should be right according to `98a12f`
markus-rothkoetter added a commit that referenced this issue Jun 29, 2022
…oms-for-photovoltaic

Add axioms for photovoltaic #1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment