Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: CAMS Timeseries #65

Closed
10 tasks done
christian-rli opened this issue Jul 28, 2020 · 3 comments · Fixed by #66
Closed
10 tasks done

Review: CAMS Timeseries #65

christian-rli opened this issue Jul 28, 2020 · 3 comments · Fixed by #66
Assignees
Labels
review Data and Metadata review

Comments

@christian-rli
Copy link
Contributor

christian-rli commented Jul 28, 2020

Issue description

I'm submitting an OEMetadata string for review.
Please see review_process.md for technical detail.

The dataset is not under an open license. The data provide time series of Global, Direct, and Diffuse Irradiations on horizontal surface, and Direct Irradiation on normal plane (DNI) for the actual weather conditions as well as for clear-sky conditions (source).

Workflow checklist

  1. GitHub
  • I have submitted this issue to have metadata review documented (Issue #NR)
  • Create a new review-branch and push OEMetadata to new branch (review/project_nameofdata#NR)
  1. OEP
  • ! The corresponding data is not open and won't be uploaded to the OEP
  1. Start a Review
  • Start a pull request (PR) from review-branch to master
  • Assign a reviewer and get in contact
  1. Reviewer section
  • A reviewer starts working on the issue
  • Review data license
  • A reviewer finished working on this issue (and awarded a badge)
  • Merge PR and delete review-branch
  • Document final links of metadata in issue description
  • Close issue

Metadata and data for review

Here are the links to my data and metadata. Naming follows the pattern model_draft.project_nameofdata:
Metadata: https://github.com/OpenEnergyPlatform/data-preprocessing/blob/review/project_nameofdata/data-review/project_nameofdata.json
Data: https://openenergy-platform.org/dataedit/view/model_draft/project_nameofdata

Reviewed and published metadata and data

Final naming and location of the metadata after the review are as follows:

  • Data will not be available on the OEP, but externally at cams
  • Metadata
@christian-rli christian-rli added the review Data and Metadata review label Jul 28, 2020
christian-rli added a commit that referenced this issue Jul 28, 2020
name refers to the spdx identifier. title is the human readible
identifier.
christian-rli added a commit that referenced this issue Jul 28, 2020
There is only one key for location, no separation of latitude and
longitude. The coordinate reference system is wgs84.
@christian-rli
Copy link
Contributor Author

I deleted several key-value pairs, because they do not appear in the metadata standard. Please note that arbitrary new keys to the metadata string are not supported as of yet. I left a note in the wiki to discuss this. Specifically the keys and values were:

under spatial:
"latitude": "36.8299",
"typeLatitude":"positive North, ISO 19115",
"longitude": "-2.4054",
"typeLongitude": "positive East, ISO 19115"

under temporal:
"timeReference": "Universal Time (UT)"

note: ISO 8601 does not seem to allow for times specified in UT / UT1. The information is quite relevant, however. We should discuss this for the next metadata version, so I added another note to the wiki

christian-rli added a commit that referenced this issue Jul 28, 2020
@christian-rli
Copy link
Contributor Author

@fradra I created this isse for the review of your CAMS timeseries metadata file and made the changes listed above. If you have any comments on this, please leave them in this issue.

@christian-rli
Copy link
Contributor Author

From what I can tell, the string is valid now, although omi seems to be unable to parse it. I filed an issue to solve this.

christian-rli added a commit that referenced this issue Jul 29, 2020
christian-rli added a commit that referenced this issue Jul 29, 2020
…timeseries#65

Include CAMS Timeseries Metadata String #65
christian-rli added a commit that referenced this issue Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Data and Metadata review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants