This repository has been archived by the owner on May 28, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adiciona página junte-se com renderização de arquivo MarkDown #86
Adiciona página junte-se com renderização de arquivo MarkDown #86
Changes from 2 commits
03ebf58
d6395a9
f009c77
e942829
3166b73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you put in a state? The markdown is static, so we don't need a state here, imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By using a state, the page will render while the MarkDown text is being obtained by
fetch
, and also I can pass its value as props forMarkDownRenderer
component.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this await is really necessary? because, in my understanding response will have a value when arrive at this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetch returns a
Response
object, and its body is aReadable Stream
. In the same way we need to usejson
async method when we want this response's body as a JSON, in this case it's necessary to get the body as a text, so I decided to usetext
method.