Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates a more designed landing page #76

Merged
merged 2 commits into from
Aug 4, 2015
Merged

Creates a more designed landing page #76

merged 2 commits into from
Aug 4, 2015

Conversation

caprenter
Copy link
Contributor

For discussion

Adds a couple of 'landing' boxes for each standard and a few other bits

@Bjwebb
Copy link
Member

Bjwebb commented Aug 4, 2015

Have rebased onto current master.

@caprenter Should there be logo images included in the repository? If so, I think you missed them from your commit.

Otherwise, looks good to me.

@caprenter
Copy link
Contributor Author

Yep - logos should be in there. Will add them.

@caprenter
Adds logos missing from previous commit and minor layout change
b0d6a76 
On looking at this again, see no reason why the boxes shouldn't be
half a page, and added a background colour so that the OCDS logo
doesn't look isolated.
Centred the text in the boxes as well
@Bjwebb Bjwebb assigned timgdavies and unassigned Bjwebb Aug 4, 2015
@Bjwebb
Copy link
Member

Bjwebb commented Aug 4, 2015

This is now up on http://minor-live-improvements.dev.cove.opendataservices.coop/ for review.

As this is a change to the look of the site, @timgdavies might want to review before this gets merged.

@timgdavies
Copy link
Contributor

I'm liking the look of this.

+1 from me.

On Tue, Aug 4, 2015 at 4:14 PM, Ben Webb [email protected] wrote:

This is now up on
http://minor-live-improvements.dev.cove.opendataservices.coop/ for review.

As this is a change to the look of the site, @timgdavies
https://github.com/timgdavies might want to review before this gets
merged.

—
Reply to this email directly or view it on GitHub
#76 (comment).

+44 (0)7834 856 303
@timdavies
http://www.timdavies.org.uk

Bjwebb added a commit that referenced this pull request Aug 4, 2015
@Bjwebb
Merge pull request #76 from OpenDataServices/minor-live-improvements
dbe91cc 
Creates a more designed landing page
@Bjwebb Bjwebb merged commit dbe91cc into master Aug 4, 2015
@Bjwebb Bjwebb deleted the minor-live-improvements branch August 4, 2015 15:25
@Bjwebb Bjwebb restored the minor-live-improvements branch August 4, 2015 15:28
@Bjwebb Bjwebb mentioned this pull request Aug 4, 2015
Closed
@Bjwebb Bjwebb mentioned this pull request Oct 7, 2015
Open
@Bjwebb Bjwebb deleted the minor-live-improvements branch November 19, 2015 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timgdavies timgdavies

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caprenter @Bjwebb @timgdavies