Add GitHub Super-Linter workflow #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace our previous lintly-flake8.yml and shellcheck.yml workflows with GitHub Super-Linter. This was motivated by a recent Lintly bug caused by the pinning of Jinja to an old version which no longer works with latest MarkupSafe version, and by the apparent fact that Lintly is no longer maintained upstream. See grantmcconnaughey/Lintly#54 and grantmcconnaughey/Lintly#55 Add Super-Linter badge to README.md, and fix errors from Super-Linter.
drotheram
approved these changes
Mar 4, 2022
DamonU2
approved these changes
Mar 4, 2022
wkhchow
approved these changes
Mar 4, 2022
jvanulde
approved these changes
Mar 4, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace our previous lintly-flake8.yml and shellcheck.yml workflows
with GitHub Super-Linter.
This was motivated by a recent Lintly bug caused by the pinning of Jinja
to an old version which no longer works with latest MarkupSafe version,
and by the apparent fact that Lintly is no longer maintained upstream.
See grantmcconnaughey/Lintly#54 and grantmcconnaughey/Lintly#55
Add Super-Linter badge to README.md, and fix errors from Super-Linter.
See https://github.com/anthonyfok/opendrr-api/runs/5363937590?check_suite_focus=true for the result of a Super-Lint run with
VALIDATE_ALL_CODEBASE: true(i.e. checking all existing files too).See sapegin/textlint-rule-terminology#38 about textlint complaining about
htmlvsHTMLin an URL. Perhaps one of these days, if I figure out how to, I would do a pull request so we no longer need the unsightly<!-- textlint-disable -->and<!-- textlint-enable -->comments in README.md.And, interesting discussion about Python Black, which Super-Linter also uses in addition to Flake8 etc.: