Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Joost's gen-pygeoapi-config branch into master #110

Merged
merged 7 commits into from
Jun 4, 2021

Conversation

anthonyfok
Copy link
Member

@anthonyfok anthonyfok commented Jun 3, 2021

This is the gen-pygeoapi-config work that Joost authored in March 2021.

The original gen-pygeoapi-config branch is duplicated as gen-pygeoapi-config--for-master and is rebased against the master branch as of today (June 3, 2021), with flake8 warnings fixed.

This (partially?) resolves works towards accomplishing #73.

Hey Joost, if you are reading this:

Copy link
Contributor

@jvanulde jvanulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced that this will be the way we generate the configuration in the future but let's at least bring it in so that we don't lose it in some obscure branch.

@anthonyfok
Copy link
Member Author

Thanks Joost!

I am not convinced that this will be the way we generate the configuration in the future but let's at least bring it in so that we don't lose it in some obscure branch.

Good point! I'll make a note of this at #73 for continued work in this area.

@anthonyfok anthonyfok merged commit d2d32d4 into master Jun 4, 2021
@anthonyfok anthonyfok deleted the gen-pygeoapi-config--for-master branch June 14, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants