Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_data.sh - curl commands (should retry for transient errors during transfer) #66

Closed
drotheram opened this issue Mar 1, 2021 · 4 comments · Fixed by #82
Closed

add_data.sh - curl commands (should retry for transient errors during transfer) #66

drotheram opened this issue Mar 1, 2021 · 4 comments · Fixed by #82

Comments

@drotheram
Copy link
Contributor

Verify downloads have completed without errors, otherwise retry downloads

@anthonyfok
Copy link
Member

Ideas:

  1. According to https://unix.stackexchange.com/questions/287431/continue-interrupted-curl-download, we can use something like:

      curl -L -O --retry 999 --retry-max-time 0 -C - http://url
    
  2. Having some kind of checksum mechanism, e.g. sha256sum, or even with GPG signature, would be nice.

Pending on completion of #68, i.e. after we have moved the multiple curl calls to its own function.

@anthonyfok
Copy link
Member

anthonyfok commented Mar 8, 2021

Notes to self:

  • Check for type: file vs dir
  • --no-act or --dry-run or something similar for add_data.sh to "predict" how much files would be downloaded before download.
  • Get sha256 checksum (Git LFS only)
$ jq -r '.content' response.json | base64 -d
version https://git-lfs.github.com/spec/v1
oid sha256:7d2487268dad05f83a0c5be6dcf90419e0bb53cf34706362baae21ac7841c2b5
size 234453739
  • Use a repo for compressed cached copies?

@jvanulde
Copy link
Contributor

jvanulde commented Apr 13, 2021

@anthonyfok are we moving to Sprint 32?

@anthonyfok anthonyfok modified the milestones: Sprint 30, Sprint 32 Apr 15, 2021
anthonyfok added a commit to anthonyfok/opendrr-api that referenced this issue Apr 19, 2021
so curl does not fail and abort upon the first transient error.

Partially solves OpenDRR#66; checksum verification yet to be added.
anthonyfok added a commit to anthonyfok/opendrr-api that referenced this issue Apr 19, 2021
so curl does not fail and abort upon the first transient error.

Partially solves OpenDRR#66; checksum verification yet to be added.
@jvanulde jvanulde linked a pull request Apr 19, 2021 that will close this issue
drotheram pushed a commit that referenced this issue Apr 19, 2021
so curl does not fail and abort upon the first transient error.

Partially solves #66; checksum verification yet to be added.
@anthonyfok anthonyfok reopened this Apr 20, 2021
@anthonyfok anthonyfok changed the title add_data.sh - curl commands add_data.sh - curl ~commands~ should retry for transient errors Apr 29, 2021
@anthonyfok
Copy link
Member

PR #82 partly solves this issue, but not quite. Please see follow-up issues #83 and #90.

@anthonyfok anthonyfok changed the title add_data.sh - curl ~commands~ should retry for transient errors add_data.sh - curl commands (should retry for transient errors during transfer) Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants