Updates july2022 #150
Merged
Updates july2022 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wkhchow
commented
Feb 15, 2023
•
wkhchow
commented
- new 3857 hexgrids
- bug fixes
- update readme/lisezmoi
- includes all updates in @drotheram's reformat_add_data branch
- W0105: String statement has no effect (pointless-string-statement) - W1202: Use lazy % formatting in logging functions (logging-format-interpolation) - W3101: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout) - R1711: Useless return at end of function or method (useless-return) - C0103: Function name "processRuptureXML" doesn't conform to snake_case naming style (invalid-name) - C0103: Variable name "logFileName" doesn't conform to snake_case naming style (invalid-name) - C0103: Variable name "ghToken" doesn't conform to snake_case naming style (invalid-name) - C0103: Variable name "configParseObj" doesn't conform to snake_case naming style (invalid-name) - C0103: Variable name "ruptureFile" doesn't conform to snake_case naming style (invalid-name) - C0411: standard import "import sys" should be placed before "import pandas as pd" (wrong-import-order) - C0411: standard import "import xml.etree.ElementTree as et" should be placed before "import pandas as pd" (wrong-import-order) - C0411: standard import "from io import StringIO" should be placed before "import pandas as pd" (wrong-import-order) Also reword the help text and comment a little bit.
This was
linked to
issues
Feb 15, 2023
anthonyfok
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
@wkhchow Looks good to me! even though there is a lot that I don't really understand. But looks really good! Thank you! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.