Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_assets.yml: Fix "Cannot upload assets for release..." #80

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

anthonyfok
Copy link
Member

Switch to xresloader/upload-to-github-release@v1, changed push trigger and add an input field for release tag for manual trigger, to try to resolve the following error when release v1.2.1 was published:

Run AButler/[email protected]
Warning: Cannot upload assets for release which is being released

See https://github.com/OpenDRR/earthquake-scenarios/actions/runs/4737851962/jobs/8411089719 for the error message in context before the workflow log expires.

Also upgrade to actions/checkout@v3, and delete Android and .NET files inside ubuntu-22.04 runner to make more room.

Switch to xresloader/upload-to-github-release@v1, changed push trigger and
add an input field for release tag for manual trigger,
to try to resolve the following error when release v1.2.1 was published:

    Run AButler/[email protected]
    Warning: Cannot upload assets for release which is being released

See https://github.com/OpenDRR/earthquake-scenarios/actions/runs/4737851962/jobs/8411089719
for the error message in context before the workflow log expires.

Also upgrade to actions/checkout@v3, and delete Android and .NET files
inside ubuntu-22.04 runner to make more room.
@anthonyfok
Copy link
Member Author

I forgot to add that this was tested successfully in my fork of the repo; see:

where the run for the fictitious v1.2.1 was triggered manually, and the run for the fictitious v1.2.2 was triggered upon creation and publishing of the v1.2.2 release tag. Thanks!

@anthonyfok anthonyfok requested a review from wkhchow April 20, 2023 21:43
William Chow (@wkhchow) generated the scenario info GeoPackage file
shakemap_scenario_extents.zip on March 7, 2023, for the 9 scenarios
of which 3 was just renamed, but I failed to notice it to commit it
to the repository.  Sorry, and Thanks!
Copy link
Collaborator

@wkhchow wkhchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't run anything on my end but checked the release/log on @anthonyfok fork.

@drotheram
Copy link

Looks fine to me

@anthonyfok anthonyfok merged commit 618e8ef into master Apr 20, 2023
@anthonyfok anthonyfok temporarily deployed to github-pages April 20, 2023 23:28 — with GitHub Pages Inactive
@anthonyfok
Copy link
Member Author

Thank you so much @wkhchow and @drotheram!

@anthonyfok anthonyfok deleted the fix-generate-assets branch April 20, 2023 23:33
@anthonyfok anthonyfok temporarily deployed to github-pages April 21, 2023 00:10 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants