Reverted usage of select_on_container_copy_construction() #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… broke libcyphal unit tests where there are unit tests which verify that there is no usage of the default PMR. `select_on_container_copy_construction()` does exactly this - it create a completely new instance of allocator: - without transferring underlining memory resource - but instead getting the default `pmr::memory_resource()`
serges147
changed the title
|
|
Closing this PR b/c with OpenCyphal-Garage/libcyphal#394 it is not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted usage of
select_on_container_copy_construction()- it broke libcyphal unit tests where there are unit tests which verify that there is no usage of the default PMR.select_on_container_copy_construction()does exactly this - it create a completely new instance of allocator:pmr::memory_resource()