Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed windows paths #239

Merged
merged 3 commits into from
Feb 26, 2022
Merged

Conversation

DNedic
Copy link
Contributor

@DNedic DNedic commented Feb 23, 2022

Fix windows paths that break building on windows, most notably because of static asserts. Backslashes were not properly escaped. In the abscence of a better fix, this replaces backslashes with double backslash in jinja templates, as backslashes should not be used on linux anyway.

@thirtytwobits
Copy link
Member

Please rebase. I've fixed our CI and upstream dependency issues. Thanks.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thirtytwobits
Copy link
Member

Cool. We'll take this and then do #243 later.

@thirtytwobits thirtytwobits merged commit ae559a8 into OpenCyphal:main Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing escape characters for DSDL source file path in Windows
3 participants