Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect verification source after deleting #623

Open
phavekes opened this issue Oct 10, 2024 · 4 comments
Open

Incorrect verification source after deleting #623

phavekes opened this issue Oct 10, 2024 · 4 comments
Assignees
Labels
bug Something isn't working id verif for eduid Tested by (T)PM Tested by SURF internaly
Milestone

Comments

@phavekes
Copy link
Member

phavekes commented Oct 10, 2024

To reproduce

  1. Validate using eidas or bank
  2. Add a role at an institution
  3. Remove the role

The name displayed is as validated by the institution, but the label shows it's validated by eherkenning.

image

Expected Behaviour:

  • If the user has an externaly validated account, and a role is added, the user is asked if he want's to use the new names as validated names for services
  • Is the preferred validation is removed, use the names last added validation method for the preferred names.
  • Always display the source of the names in the overview's "validated by" field
@Tyskai
Copy link
Collaborator

Tyskai commented Oct 28, 2024

Unfortunately this problem is not fixed. Or even created a new problem (related to 630)

  1. Validate using eidas
  2. Add a role at an institution, click "no, do not use"

Expected: the information of the user has "eherkenning" and the eIDAS name
Actual behaviour: the information of the user has "example.com" = the institution, while having the eIDAS name

Screenshot 2024-10-28 at 19 16 41

@oharsta oharsta moved this from New to In Progress in Openconext-Myconext Oct 29, 2024
oharsta added a commit that referenced this issue Oct 29, 2024
@oharsta
Copy link
Member

oharsta commented Oct 31, 2024

Added test in 919235e. Moving to to-be-tested

@oharsta oharsta closed this as completed Oct 31, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Delivered in Openconext-Myconext Oct 31, 2024
@Tyskai Tyskai self-assigned this Oct 31, 2024
@Tyskai Tyskai reopened this Oct 31, 2024
@github-project-automation github-project-automation bot moved this from Delivered to New in Openconext-Myconext Oct 31, 2024
@Tyskai
Copy link
Collaborator

Tyskai commented Oct 31, 2024

I found a bug that still keeps some "instelling data".
Screenshot 2024-10-31 at 16 52 20
Reproduce by:

  1. add iDIN
  2. then add institute 1 (prefer it)
  3. then institute2 (prefer it)
  4. delete institue 2
  5. delete institue 1
    Expected: only IDIN data is there (and verified)
    Actual behaviour: my institute 1 given name (ins1) seems to be verified by iDIN! In addition to the other data I have from iDIN.

@Tyskai
Copy link
Collaborator

Tyskai commented Nov 12, 2024

Tested again! Now all my test cases seem to work!

@Tyskai Tyskai added the Tested by (T)PM Tested by SURF internaly label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working id verif for eduid Tested by (T)PM Tested by SURF internaly
Projects
Status: Ready for release
Development

No branches or pull requests

3 participants