Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SAML binding configurable via idp.saml_binding #86

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

mloesch
Copy link
Contributor

@mloesch mloesch commented Jun 28, 2023

Currently the SAML redirect binding is hardcoded in the IDP configuration. However, our SP only works with the HTTP POST binding.

This PR makes the binding type configurable via a property. I tested this with the HTTP POST binding (urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST) against our SAML SP and it works fine.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (71528b3) to head (215b52f).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage     91.25%   91.25%           
  Complexity      165      165           
=========================================
  Files            30       30           
  Lines           583      583           
  Branches         17       17           
=========================================
  Hits            532      532           
  Misses           37       37           
  Partials         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thijskh thijskh requested a review from oharsta June 28, 2023 08:49
@oharsta oharsta merged commit d881c3b into OpenConext:master Aug 29, 2023
3 checks passed
Copy link
Member

@oharsta oharsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Merged (and added urn:oasis:names:tc:SAML:attribute:subject-id to the default attributes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants